Skip to content

chore: Stop publishing swagger-validator WAR to Maven Central - #295

Merged
ewaostrowska merged 2 commits into
masterfrom
remove-war
Nov 19, 2026
Merged

ewaostrowska merged 2 commits into
masterfrom
remove-war

Conversation

@ewaostrowska

Copy link
Copy Markdown
Collaborator

io.swagger.validator.v3:swagger-validator is a WAR. The Docker image swaggerapi/swagger-validator-v2 is the real release artifact, so the Maven Central publish (snapshots on every master push, releases via GPG signing) is no longer needed.

Why the whole deploy is removed, unlike swagger-codegen #12783

swagger-codegen #12783 kept the Central deploy and only excluded one artifact. It added <excludeArtifact>swagger-generator</excludeArtifact> to central-publishing-maven-plugin and a README note. That works there because codegen is a multi-module build. The swagger-generator WAR is one module among several libraries (such as codegen and the CLI) that still need to be published.

validator-badge is a single-module project with packaging=war. Its only Maven artifact is the WAR, plus the sources jar, javadoc jar and POM that exist only to satisfy Central. Excluding the WAR would leave a deploy that publishes nothing. So the whole chain is removed instead:

  • the publishing plugin,
  • the snapshot deploy,
  • the -Prelease deploy step,
  • the GPG signing, which only signed Central artifacts,
  • the source and javadoc plugins, which existed only for Central.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The release workflow still lacks the Maven build needed to generate the JAR and WAR files that the subsequent Docker build copies, so releases will fail on fresh runners.

1 open issue
What changed in this PR

This pull request stops publishing the single-module WAR to Maven Central and makes the Docker image the project’s release artifact.

Changes:

  • Removes Maven Central publishing, signing, source, and Javadoc configuration from pom.xml.
  • Removes Maven deployment credentials and deploy steps from GitHub Actions workflows.
  • Updates README and CI documentation to describe Docker-based releases and local WAR builds.
File Description
README.md Documents the discontinuation of Maven Central publication and directs users to Docker or local source builds.
pom.xml Removes Maven Central publishing, GPG signing, source JAR, and Javadoc JAR configuration.
CI/​CI.md Updates CI and release documentation to reflect Docker-only publishing.
.github/​workflows/​release.yml Removes Maven Central credentials and release deployment steps.
.github/​workflows/​prepare-release.yml Removes obsolete Maven Central setup and credentials.
.github/​workflows/​maven.yml Changes master CI from snapshot deployment to Maven package verification.
.github/​workflows/​maven-pulls.yml Removes unused Maven Central setup from pull-request CI.

Review effort: Lite

Comment thread .github/workflows/release.yml Resolved
Comment thread pom.xml Resolved
Comment thread pom.xml Resolved
Comment thread pom.xml Resolved
@ewaostrowska
ewaostrowska merged commit d2ab14e into master Nov 19, 2026
4 checks passed
@ewaostrowska
ewaostrowska deleted the remove-war branch November 19, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants