fix: exclude relative imports from tracing interception - #17005
Draft
svelte-triage-bot[bot] wants to merge 1 commit into
Draft
fix: exclude relative imports from tracing interception#17005svelte-triage-bot[bot] wants to merge 1 commit into
svelte-triage-bot[bot] wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/f2eeb2cffedaf952865b3781e86a5cda8f7d135aOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17004.
Problem
The observability quickstart used a bare
import-in-the-middleregister()call. This caused relative server chunks to be wrapped, snapshotting Svelte's mutablessr_contextESM export and crashing SSR components that callonDestroy.Fix
import-in-the-middleregistration to exclude relative imports.onDestroy.Verification
pnpm -F @sveltejs/kit test:unitpnpm -F test-basics checkpnpm lintpnpm checkpnpm format