fix: preserve -0 in float typed arrays in uneval - #178
Merged
Rich-Harris merged 1 commit intoAug 20, 2026
Conversation
uneval serialized Float32Array/Float64Array/Float16Array elements via Array.prototype.toString, which renders -0 as "0", so a negative zero silently became +0 on round-trip. stringify is unaffected (it encodes the raw buffer as base64). Emit "-0" explicitly for those elements. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 706b2b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug —
unevalloses the sign of-0in float typed arrays:Cause:
stringify_typed_array_elementsserializes non-BigInt typed-array elements withArray.prototype.toString, which renders-0as"0".stringifyis unaffected because it base64-encodes the raw buffer, so the two serializers disagree and onlyunevaldrops the sign bit.Fix: for
Float32Array/Float64Array/Float16Array, map elements and emit-0explicitly (viaObject.is); integer arrays keep the fasttoStringpath.Float16Arrayistypeof-guarded so nothing throws on Node without it.Evidence: added a
Float64Array([-0, 1.5])fixture (fails before, passes after); full suite 797/797,build+publintclean.