feat(migrate): move Kit 3 setup out of the experimental add-on - #1241
Open
manuel3108 wants to merge 2 commits into
Open
feat(migrate): move Kit 3 setup out of the experimental add-on#1241manuel3108 wants to merge 2 commits into
manuel3108 wants to merge 2 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/sv/c/3da1c0217a820ac9be0ae0eba27dba9677682318Open in |
🦋 Changeset detectedLatest commit: 3da1c02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #1124
Description
Given that
sv@1now targetskit@3, theexperimentaladdon needs to change. Well not directly, but given that we will publishsv migrate sveltekit-3in the same step, we can safely assume that the user is either onkit@3or will use the migration to get there. Therefore the migration no longer needs to bump the peer deps or change any$lib/#libstuff. Both things are therefore moved into its own migration task.The only remaining task of the
experimentaladdon is to enableexperimentaloptions. Thats it. As it should have been.Checklist