chore: use `tinyexec` by sacrosanctic · Pull Request #1213 · sveltejs/cli

sacrosanctic · 2026-08-01T11:11:59Z

Closes #

Description

Checklist

Update snapshots (if applicable)
Add a changeset (if applicable)
Allow maintainers to edit this PR
I care about what I'm doing, no matter the tool I use (Notepad, Sublime, VSCode, AI...)

* main * throw if pm isnt installed * throw * nit * changeset * tmv sv ordering * sh is unknwon on windows (execSync know about it) * hint to label & next step * caching agent install, keep none by default --------- Co-authored-by: jycouet <jycouet@gmail.com>

Bump package-manager-detector to ^1.8.0, the first release with nub in its agent and command tables. sv-utils bundles the library at build time, so the published bundle only knows about nub once rebuilt against >=1.8.0.

…eltejs#1192) When prettier is among the scaffolded add-ons, format the whole project rather than only the add-on-touched files, so a fresh project passes its own lint. Prettier's ignore rules still apply. Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>

* feat: addOption in setup phase * fmt² * okay cut * humm * fmt * chore: update api surface * test: await async setupAddons in engine tests * Update packages/sv/src/core/config.ts Co-authored-by: Scott Wu <sw@scottwu.ca> * Update packages/sv/src/core/config.ts Co-authored-by: Scott Wu <sw@scottwu.ca> * feat: typesafe addOption keys via defineAddon setup generic - addOption now constrains key + question type from defineAddon<SetupValues>() - regenerate api surface --------- Co-authored-by: Scott Wu <sw@scottwu.ca>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* mv * feat: welcome `ai-tools` * abc * don't format skills * opencode -> plugin, claude question, subagents * fmt * cleanup snap * snap * update new path * feat(ai-tools): choose Svelte plugin or individual tools per client - delivery option: Svelte plugin (Claude via committed .claude/settings.json, opencode via opencode.json) or individual tools - granular MCP/skills/sub-agents selection; rename `setup` -> `mcpSetup` - consolidate per-client config into a single `CLIENTS` registry * feat(ai-tools): install skills for cursor, gemini and vscode * feat(ai-tools): CLAUDE.md imports AGENTS.md to keep a single source of truth * chore(ai-tools): rename RX_MD to REGEX_MD * feat(ai-tools): warn in next steps when plugin and loose skill/agent files coexist * fmt * fix(ai-tools): 'other' client now writes AGENTS.md * fix(ai-tools): only ask tool/MCP questions when a client can use them * Update packages/sv/src/create/shared/+skills/svelte-code-writer/SKILL.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update documentation/docs/30-add-ons/01-ai-tools.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update documentation/docs/30-add-ons/01-ai-tools.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update documentation/docs/30-add-ons/01-ai-tools.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update documentation/docs/30-add-ons/01-ai-tools.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/addons/ai-tools.ts Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/addons/ai-tools.ts Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+skills/svelte-code-writer/SKILL.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+skills/svelte-code-writer/SKILL.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+skills/svelte-code-writer/SKILL.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+skills/svelte-code-writer/SKILL.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/addons/ai-tools.ts Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/addons/ai-tools.ts Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * update skills * fix: drop stale reference files and update ai-tools snapshots --------- Co-authored-by: Rich Harris <hello@rich-harris.dev>

…rrors (sveltejs#1198) * fix: drop obsolete pnpm allowBuilds entries and surface real format errors * test: install generated project outside the repo workspace

…t 3 shape (sveltejs#1199) * feat(sv-utils): add SvelteKit 3 helpers Version detection, the `$lib` -> `#lib` move and the generated `$app/tsconfig`, so add-ons stop hardcoding kit-version-specific shapes. * fix(core): make `runsAfter` actually order add-ons It sorted by number of constraints, so an add-on could still run before one it declared it runs after. Topologically sort instead, seeded with the previous order so unconstrained add-ons keep their relative position. * fix(experimental): create manages `#lib` and the rest of the SvelteKit 3 shape - skip `handleRenderingErrors`/`explicitEnvironmentVariables`, removed in kit 3 - extend `$app/tsconfig` and own `include`, keeping deliberate compiler option overrides - rewrite `$lib` to `#lib` and declare the subpath imports Vite resolves from - drizzle drops the removed `typescript.config` hook; `defineEnvVars` moves to `@sveltejs/kit/env` - better-auth and paraglide emit the right lib prefix and route type * test(cli): cover `kit@next` with a real install, build and check No snapshot: the point is that the project works, not what it looks like. * Update packages/sv/src/addons/drizzle.ts Co-authored-by: Scott Wu <sw@scottwu.ca> * Update packages/sv-utils/src/kit3.ts Co-authored-by: Scott Wu <sw@scottwu.ca> * test(cli): cover better-auth on `kit@next`, finish the `KIT3_TSCONFIG_DEFAULT` rename better-auth has the most `#lib` imports, so it gets its own `kit@next` install/build/check case. It can't join the existing one: kit treats any `remote.js` as a remote module, including the one `jose` ships, so `remoteFunctions` breaks the build. Also rewords the changeset and updates the two remaining `KIT3_TSCONFIG_INHERITED` references. * test(cli): pin the `kit@next` prereleases the experimental cases run against * test(cli): drop the better-auth `kit@next` case * chore: fix indentation * test(cli): let the generated project install a fresh prerelease * test(cli): track the `next` tag instead of a pinned prerelease * chore: trim the changesets to one line each * chore: changeset wording --------- Co-authored-by: Scott Wu <sw@scottwu.ca>

* remove `better-sqlite3` from `allowBuilds` * changeset * Update packages/sv/src/addons/drizzle.ts Co-authored-by: CokaKoala <31664583+AdrianGonz97@users.noreply.github.com> * changeset --------- Co-authored-by: CokaKoala <31664583+AdrianGonz97@users.noreply.github.com>

…sveltejs#1201)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

pkg-svelte-dev · 2026-08-01T11:12:02Z

Install the latest version of sv from a0c7755:

pnpm add https://pkg.svelte.dev/sv/c/a0c77558e938bac6bc25da4e454bdb5eb93d0e8e

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/cli/pr/1213

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

changeset-bot · 2026-08-01T11:12:02Z

⚠️ No Changeset found

Latest commit: a0c7755

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sacrosanctic

Not sure if these are supposed to throw.

AdrianGonz97 · 2026-08-01T22:43:54Z

+		await exec(command, args, { nodeOptions: { cwd }, throwOnError: true });
 		return {};
 	} catch (e) {
 		// @ts-expect-error tinyexec rethrows the spawn error as-is


// @ts-expect-error tinyexec rethrows the spawn error as-is

I know you didn't change this catch-block, but is this still correct? Looking through NonZeroExitError, I don't see e.code as an available prop.

e.code is a node error. I'll update the code to clarify this.

AdrianGonz97 · 2026-08-01T23:13:43Z

 	}

-	if (dockerInstalled) execSync('docker compose up --detach', { cwd, stdio: 'pipe' });
+	if (dockerInstalled) execSync('docker', ['compose', 'up', '--detach'], { nodeOptions: { cwd } });


this one should probably throw (or at least be handled in some way) as well if we're depending on it running successfully

AdrianGonz97 · 2026-08-01T23:16:28Z


 fs.writeFileSync(path.join(test_workspace_dir, 'pnpm-workspace.yaml'), 'packages:\n  - ./*\n');

-const exec_async = promisify(nodeExec);


hmmm, there was a reason we used this instead due to failing tests, but if it's no longer failing then we're probably good

Co-authored-by: CokaKoala <31664583+AdrianGonz97@users.noreply.github.com>

sacrosanctic · 2026-08-03T01:00:07Z

I just learned that execsync still throws even when it is false if the command itself is invalid...

sacrosanctic and others added 19 commits July 23, 2026 15:46

fix: recognize the nub package manager (sveltejs#1187)

580c2f7

Bump package-manager-detector to ^1.8.0, the first release with nub in its agent and command tables. sv-utils bundles the library at build time, so the published bundle only knows about nub once rebuilt against >=1.8.0.

Version Packages (sveltejs#1191)

063258f

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: drop obsolete pnpm allowBuilds entries and surface real format e…

9b3fa17

…rrors (sveltejs#1198) * fix: drop obsolete pnpm allowBuilds entries and surface real format errors * test: install generated project outside the repo workspace

fix(better-auth): use the auth CLI binary in the auth:schema script (…

1a67d26

…sveltejs#1201)

Version Packages (sveltejs#1200)

78f6b7a

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

drop in replacement

fdcf48f

add run helper that defaults cwd to testOutputPath

c791d83

refactor out constructCommand

2115be4

refactor to no throw

1fc25b7

tinyexec doesn't throw by default

21bef99

clean up

d7d20f9

every exec on this page should throw?

696efaa

not sure if this is a one to one refactor

f44f36e

sacrosanctic commented Aug 1, 2026

View reviewed changes

Comment thread packages/sv/src/testing.ts Outdated

Comment thread packages/sv/src/testing.ts Outdated

sacrosanctic commented Aug 1, 2026

View reviewed changes

Comment thread packages/sv/src/addons/tests/vitest/test.ts

sacrosanctic added 5 commits August 1, 2026 19:15

lint

390a6ea

fix

78030c6

fix

e48f361

nit

20674ce

rerun test

764cf6a

AdrianGonz97 reviewed Aug 1, 2026

View reviewed changes

Update packages/sv/src/core/verifiers.ts

ea6eb58

Co-authored-by: CokaKoala <31664583+AdrianGonz97@users.noreply.github.com>

sacrosanctic added 7 commits August 3, 2026 16:03

adjust throws

6901b16

lint

584df66

Clarify where error properties come from

4b0773d

throw

9b31da4

more throws

1ab1830

no type casting

4b83db5

add isNodeError

a0c7755

manuel3108 changed the base branch from main to version-1 August 7, 2026 08:52


		fs.writeFileSync(path.join(test_workspace_dir, 'pnpm-workspace.yaml'), 'packages:\n - ./*\n');

		const exec_async = promisify(nodeExec);

Uh oh!

Uh oh!

Conversation

sacrosanctic commented Aug 1, 2026

Description

Checklist

Uh oh!

pkg-svelte-dev Bot commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

sacrosanctic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AdrianGonz97 Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sacrosanctic Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AdrianGonz97 Aug 1, 2026

Choose a reason for hiding this comment

Uh oh!

AdrianGonz97 Aug 1, 2026

Choose a reason for hiding this comment

Uh oh!

sacrosanctic commented Aug 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pkg-svelte-dev Bot commented Aug 1, 2026 •

edited

Loading

changeset-bot Bot commented Aug 1, 2026 •

edited

Loading

AdrianGonz97 Aug 1, 2026 •

edited

Loading