Repository navigation
fix(hls): preserve caller isolation in persistent HTTP reads - #837
Open
brandomoore wants to merge 2 commits into
Open
brandomoore wants to merge 2 commits into
brandomoore wants to merge 2 commits into
Conversation
Keep the non-Sendable chunked framing on the cancellation handler caller's isolation rather than sending it to the generic executor. Add chunked read coverage through cancellation handlers. Copilot-Session: e3687c50-89d2-4a1a-86ea-dc2326878fc6
Keep the progress closure in the same isolation through nextBytes as well; exercise a progress callback that reads the consumer's accumulated bytes. Copilot-Session: e3687c50-89d2-4a1a-86ea-dc2326878fc6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore Swift 6.4 compilation of persistent HTTP body reads without making mutable chunked framing or progress closures
Sendable.The 7.40.0 source fails in a consuming tvOS application with
sending 'current' risks causing data racesinBody.next(). Adding isolation only toreadChunkreveals the same error forprogresswhen it reachesnextBytes.What changed
readChunkandnextByteswith anisolated (any Actor)? = #isolationparameter. This keeps framing and progress callbacks in the caller's isolation domain across both awaits.Sendableconformances.Test plan
Issue732PersistentHTTP1Testspassed with no skips, includingtestChunkedReadsKeepFramingAcrossCancellationHandlers. The new test verifies the complete payload and reusable final framing.Checklist
CHANGELOG.mdupdatedfeat(...),fix(...),chore(...))