Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An external subtitle without explicit headers currently receives the media's headers even when its first request goes to a different origin. Limit that implicit grant to the same HTTP scheme, host and effective port; a host can still explicitly grant headers to another subtitle server.
What changed
Test plan
Host: Apple Silicon Mac17,3, macOS 26.7.1, Swift 6.4. Synthetic SRT from local HTTP origins; assertions inspect headers observed by the server through returned cue text. Both primary and secondary selection are exercised, alongside origin/default-port/explicit-header cases and both native and remote-HLS fill jobs. No movie bytes, credentials or device playback evidence are included.
LIBDISPATCH_COOPERATIVE_POOL_STRICT=1passed. Test bundle and CLI were signed and verified with an Apple Development identity; linker ad-hoc signing was disabled.swift test --skip-build --no-parallelpassed: 795 XCTest cases (one existing skip), 4,617 Swift Testing tests in 635 suites.LiveStreamRefusalRetryTests.refusedPastTheBudgetGivesUpwall-clock assertion (two retries within its one-second budget instead of at least three). All seven tests in that suite passed immediately in isolation. A subsequent full parallel run also hit volatile-memory history assertions inSoftwarePacketMemoryFIFOTests; all 11 tests passed in isolation. A final full serial run passed. These unrelated production paths and tests were not changed; the unsuccessful runs are retained in local evidence.Scripts/check-doc-links.pyandgit diff --checkpassed. Platform builds and all-traits coverage are left to upstream CI; no device playback run is claimed.Checklist