Skip to content

fix(web): reset command palette selection when the result list changes #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhay-codes07 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

fix(web): reset command palette selection when the result list changes #1265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions apps/web/components/documents-command-palette.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,16 @@
for (const a of actions) items.push(a)
}

// Reset selection on items change
// biome-ignore lint/correctness/useExhaustiveDependencies: search is the trigger — snap the selection back to the top result whenever the query changes
useEffect(() => {
setSelectedIndex(0)
}, [])
}, [search])

// Keep the selection in range when the list shrinks (async results
// replacing recent docs, refetches, etc.)
useEffect(() => {
setSelectedIndex((i) => Math.min(i, Math.max(items.length - 1, 0)))
}, [items.length])

// Scroll selected into view
useEffect(() => {
Expand Down Expand Up @@ -252,7 +258,7 @@
if (item) handleSelect(item)
}
},
[items, selectedIndex, handleSelect],

Check warning on line 261 in apps/web/components/documents-command-palette.tsx

View workflow job for this annotation

GitHub Actions / Quality Checks

lint/correctness/useExhaustiveDependencies 

items changes on every re-render and should not be used as a hook dependency.
)

function renderItem(item: PaletteItem, index: number) {
Expand Down
Loading