Add LongMemEval-V2 benchmark adapter#48
Conversation
There was a problem hiding this comment.
Summary
Reviewed — found 2 issue(s). This PR adds the longmemeval-v2 benchmark adapter and wires it into the benchmark registry and CLI. The review focused on correctness and benchmark validity for the new adapter path.
Findings
src/benchmarks/longmemeval-v2/index.ts
loadTrajectorySessions()currently materializes the fulltrajectories.jsonlfile before filtering, which is likely to OOM or stall with the official dataset.- Image-backed questions keep
item.imageonly in metadata, so the answer/search pipeline evaluates those prompts without their visual premise.
Verdict
| ): Map<string, UnifiedSession[]> { | ||
| const sessions = new Map<string, UnifiedSession[]>() | ||
|
|
||
| for (const trajectory of readJsonl<LongMemEvalV2Trajectory>(trajectoriesPath)) { |
There was a problem hiding this comment.
readJsonl() materializes the entire trajectories.jsonl file before this filter runs. The official LongMemEval-V2 trajectory file is about 1.2GB, so commands such as run, compare, and list-questions can OOM or stall before ingestion starts. Please stream the JSONL line-by-line and retain only entries whose trajectory.id is in selectedTrajectoryIds.
| metadata: { | ||
| domain: item.domain, | ||
| environment: item.environment, | ||
| image: item.image, |
There was a problem hiding this comment.
item.image is preserved only in metadata, but the benchmark question passed to the answer/search pipeline remains just item.question. The upstream dataset includes image-dependent prompts, so those examples will be evaluated without the screenshot context and can produce invalid benchmark results. Please add a consumable multimodal/OCR representation or explicitly filter unsupported image-backed questions.
TestingScoped adapter and CLI testing passed for the new Commands run: cd /memory/testing/memorybench && chmod +x seed.sh && ./seed.sh
export PATH=/home/ubuntu/.bun/bin:$PATH
bun run src/index.ts help benchmarks
bun run src/index.ts run
bun run src/index.ts list-questions -b longmemeval-v2 -l 1
bun run src/index.ts list-questions -b longmemeval-v2 -l 10
bun run src/index.ts list-questions -b longmemeval-v2 -t workflow -l 10
bun /tmp/memorybench-lme-v2-adapter-check-relative.ts
bun run src/index.ts list-questions -b longmemeval-v2 -l 5
bun /tmp/memorybench-lme-v2-real-sample-assert.ts
bunx prettier --check src/benchmarks/README.md src/benchmarks/index.ts src/benchmarks/longmemeval-v2/index.ts src/benchmarks/longmemeval-v2/types.ts src/cli/index.ts src/types/benchmark.ts
bun run format:check
bun run src/index.ts ingest -p filesystem -b longmemeval-v2 -r testing-lme-v2-1783492734 --force
git status --shortResult: Logs are available at: Verdict
|
|
Added a follow-up commit with:
|
Summary
longmemeval-v2benchmark adapter that loads localquestions.jsonl,trajectories.jsonl, andhaystacks/lme_v2_<tier>.json