Bump fly-go to v0.9.7 and macaroon to v0.3.1 - #5122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the fix for interactive third party discharges timing out while the user is still completing a browser login.
Context
The discharge client polled the third party on an unbounded doubling backoff inside a hardcoded 30 second context, so requests landed at t=0,1,3,7,15 and the next one was scheduled past the deadline: nothing was polled for the second half of the budget. A login finished in that window produced a discharge the CLI never collected, and
Tokens.Updatereturnedcontext deadline exceededeven though the browser reported success.superfly/fly-go#286 caps the polling interval at a second and raises the discharge timeout to 90 seconds, now configurable per call through
tokens.WithDischargeTimeout. superfly/macaroon#46 makes the poll loop clamp its backoff against the caller's deadline, so a final poll always lands before the context expires.Worth knowing when reading the new numbers:
refreshDischargeTokensininternal/config/tokens.gocallsTokens.Updatetwice, each building its own context, so the worst case a user can observe is about twice the timeout fly-go uses.