feat: add noLinks and lang parameters to web.scrape method#26
Open
pvbang wants to merge 1 commit into
Open
Conversation
Add support for the missing noLinks and lang parameters in the web scrape function to maintain feature parity with the REST API. - noLinks (bool): Whether to exclude Markdown links from the response - lang (str): Language to request content in (ISO 639-1 code) Both parameters are optional and backward-compatible. Closes supadata-ai#19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for the missing
noLinksandlangparameters in theweb.scrape()method to maintain feature parity with the REST API documentation.Changes
no_links(Optional[bool]) parameter toweb.scrape()- controls whether to exclude Markdown links from the responselang(Optional[str]) parameter toweb.scrape()- language to request content in (ISO 639-1 code)Tests
All 60 tests pass (including 4 new tests for the added parameters).
Closes #19