Repository navigation
Conversation
Old pgrx versions (before 0.11.3) need an older clang to build on aarch64-linux. We got it by downloading the whole nixos-22.11 tarball during eval. That download was slow, could not come from our binary cache, and ran on every platform. Take clang 12 from nixpkgs-oldstable instead and only apply it on aarch64-linux like the comment implies. nixpkgs-oldstable's oldest clang is 12 while 22.11 defaulted to 11, but the build succeeds where a newer clang would fail. Assisted-by: Claude <noreply@anthropic.com>
Collaborator
Author
|
Draft to see if clang12 works or not. |
Package version diff: none () |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Gardening
What is the current behavior?
We fetch nixpkgs-22.11 during nix eval, every eval.
What is the new behavior?
We don't do that any more, making eval go slightly faster.