Update uid/gid pins for qemu - #2418
Open
mmlb wants to merge 2 commits into
Open
Conversation
The qemu build setup is a bit different than the AMI so ends up with different uid/gids. For example the ubuntu user/group already exists since we do an in place build instead of debootstrap like in the AMI.
We should be testing qemu build output just like arm64 (and recently amd64). This is based on ami-build-arm64 with minimal changes to get it to pass. I opted for this so we can see differences between all the different baselines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix and feature!
What is the current behavior?
We aren't building the qemu images because of uid/gid conflicts, but more importantly we don't treat qemu image builds like the AMI builds and don't check the output with supascan.
What is the new behavior?
Ansible explicitly creates users/groups with same uid/gids as we had previously and supascan verifies the qemu build artifact.