refactor(core): share the docs guide-read check across docs evals - #230
Draft
czenko wants to merge 2 commits into
Draft
refactor(core): share the docs guide-read check across docs evals#230czenko wants to merge 2 commits into
czenko wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
czenko
commented
Aug 24, 2026
| * check a red run is ambiguous: the guide may have taught the wrong thing, or | ||
| * the agent may never have opened it. | ||
| */ | ||
| export function checkDocsGuideRead( |
Contributor
Author
There was a problem hiding this comment.
Worth noting, since this is an architectural decision: this is the first CheckResult builder in core. Core has parsed traces into data and left the pass/fail decision to evals until now.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
czenko
force-pushed
the
core/share-docs-guide-read-check
branch
from
August 24, 2026 17:09
53a5412 to
8c98b7c
Compare
czenko
commented
Aug 24, 2026
czenko
marked this pull request as draft
August 25, 2026 17:21
Contributor
Author
|
Parking this as a draft per the thread. #212 is unstacked and standalone on Holding until the structured docs-injection idea is decided. If a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build-docs-002-rls-guidebuilds its guide-read check by hand, and the API keys eval in #212 carries the same function again. Same filter, samehasContentsplit, same three-way notes string, same comment above it. The only difference is the guide's name.Ten more docs evals are scoped. Each one points an agent at a page and needs to know whether the agent retrieved it, because without that a red run can't distinguish a guide that taught the wrong thing from a guide the agent never opened.
Solution
checkDocsGuideRead(toolCalls, { path, label })todocs-results.ts, besidebuildDocsResult. It returns theCheckResultthe eval-local copies were building.build-docs-002-rls-guideat it and deletes the local copy.Manual testing
pnpm --filter @supabase-evals/core test. 56 pass, including three newcheckDocsGuideReadcases.pnpm typecheck. Clean. It coversevals/**/EVAL.ts.build-docs-002-rls-guide/EVAL.tsdiff. Confirm the name passed tolabelreproduces the removed check's name exactly.