Updates to make it run on newer version of Msal.js node package#2
Open
aredfox wants to merge 2 commits into
Open
Updates to make it run on newer version of Msal.js node package#2aredfox wants to merge 2 commits into
aredfox wants to merge 2 commits into
Conversation
…that --alowJs flag for TS is on, otherwise compilations fails. Added the "any" type in stead of the "Msal.User" as it wasn't recognized.. Typings might be missing or changed?
…response in <code> tag.
Owner
|
@aredfox Could you please remove package-lock.json from your commit? I just added it to .gitignore. |
Author
|
ok, will do, give me a couple of days then i'm back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "out" folder was changed to "dist" folder for MSAL.js. Made sure that --alowJs flag for TS is on, otherwise compilations fails. Added the "any" type in stead of the "Msal.User" as it wasn't recognized.. Typings might be missing or changed?