build(lint): register @shadcn/lint in both oxlint configs - #34
Merged
Merged
Conversation
Adds the design-system linter as a js plugin in oxlint.config.ts and in apps/fumadocs/.oxlintrc.json, with no rule enabled: the rule choice is a design decision, and the upstream setup stops here. Discovery needs one setting. apps/web/components.json already points at @freenary/ui/components and at the theme, but neither app's own compositions sit behind a components.json alias, so settings.shadcn.componentImports names the @/shared/ui prefix they share. packages/ui stays ignored: its components are the design system. Probed with the rules temporarily forced on through the real configs: no-restyle names the real cva ladder of Button, no-raw-colors lists the real theme tokens, and both apps resolve against their own theme file. Zero warnings in either app, which is what proves the aliases resolve.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
suiramdev
added a commit
that referenced
this pull request
Sep 19, 2026
fix(ui): declare cn 0.2.6 and verify the bump #34 shipped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registers
@shadcn/lint0.1.1 as an Oxlint JS plugin in both lint configs — the rootoxlint.config.tsandapps/fumadocs/.oxlintrc.json— and enables no rule of it. Setup only: the rule choice is a design decision, and upstream's SETUP.md stops at registration. Look atsettings.shadcnfirst; it is the only thing discovery could not work out on its own.Motivation
packages/uiis already inignorePatterns, which is the correct blast radius: its components are the design system.Drawbacks
cnis 0.2.5 and its grammar wants 0.2.6, so it falls back to its bundled copy. It therefore reasons about class merging with a slightly different grammar than the app runs.apps/fumadocsdoes not inherit the root config.Prior art
@jliocsar/begone-slop, in exactly this shape.shadcn-ui/lintdocuments the ESLint and Oxlint setups and explicitly leaves rules off after install.cnbump was left out on purpose: it is a runtime dependency of every component, and this repo has a documented procedure for proving a class-merge version change alters no output.Notes
contributing/index.mdxgains the plugin and how to switch a rule on, andpackages/ui/AGENTS.mdrecords why the ignore is correct for that package.bun run checkclean over 649 files,bun run check-types,bun run docs:check38 pages / 0 errors / 0 warnings,cd apps/fumadocs && bun run lintexit 0.no-restylequoted Button's realcvaladder(default, compact, icon, icon-compact)and its real path,no-raw-colorslisted the real theme tokens,apps/fumadocsresolved against its ownsrc/shared/uiandapp.css, and both apps reported 0 warnings — an unresolved alias or theme would have shown up there.cnto 0.2.6 with the class-merge proof, then choose rules.