Conversation
koppen
commented
Aug 10, 2026
koppen
commented
Member
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Flowbite::Spinner ViewComponent to the Flowbite components library, including a Lookbook preview and Minitest coverage, and documents the addition in the changelog.
Changes:
- Introduces
Flowbite::Spinnercomponent (Ruby + ERB sidecar) with size/style variants and screen-reader message support. - Adds Lookbook preview scenarios for spinner styles/sizes and custom classes.
- Adds component tests and updates documentation artifacts (changelog + YARD checksums).
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
app/components/flowbite/spinner.rb |
Adds the Flowbite::Spinner component API and variant class composition. |
app/components/flowbite/spinner/spinner.html.erb |
Defines the spinner markup (status container, SVG, SR-only message). |
test/components/flowbite/spinner_test.rb |
Adds rendering, accessibility, size/style, and HTML attribute tests. |
demo/test/components/previews/spinner_preview.rb |
Adds Lookbook preview examples for styles/sizes and custom classes. |
CHANGELOG.md |
Records the Spinner component under “Unreleased / Added”. |
demo/.yardoc/checksums |
Updates YARD checksum tracking for the new component file. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
It should be covered by the Tailwind CSS class `fill-current` instead of using the invalid `currentFill` value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.