Skip to content

[sophora-youtube-connector] ExtraEnvVarsSecret replaced with envFrom - #309

Merged
DanielRaapDev merged 3 commits into
subshell:mainfrom
boossubshell:avtool-extrasecrets
Oct 9, 2026
Merged

DanielRaapDev merged 3 commits into
subshell:mainfrom
boossubshell:avtool-extrasecrets

Conversation

@boossubshell

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The test values render invalid Kubernetes envFrom entries, and the breaking configuration migration remains inconsistently documented and versioned.

3 open findings
What changed in this PR

Replaces secret-specific environment configuration with Kubernetes envFrom support.

Changes:

  • Adds envFrom values and StatefulSet rendering.
  • Updates test values and chart release metadata.
  • Documents the change in the changelog.
File Description
values.yaml Adds envFrom defaults.
test-values.yaml Migrates example environment sources.
templates/​statefulset.yaml Renders envFrom for both containers.
Chart.yaml Updates version and Artifact Hub annotation.
CHANGELOG.md Records the configuration change.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread charts/sophora-youtube-connector/test-values.yaml Outdated
Comment thread charts/sophora-youtube-connector/Chart.yaml Outdated
Comment thread charts/sophora-youtube-connector/values.yaml
@DanielRaapDev
DanielRaapDev merged commit da2916c into subshell:main Oct 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants