Migrate tests/test_gpu_aamp.py to npt.assert_allclose - #1190
Open
viknesh-ai wants to merge 1 commit into
Open
Conversation
|
Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1190 |
Contributor
Author
|
@seanlaw next file in the split — same conventions as the previous PRs. Ready for review whenever you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1175
Covers
tests/test_gpu_aamp.py(34 call sites, this file's tests only actually run under CUDA — locally it's a single module-level skip, so I verified withNUMBA_ENABLE_CUDASIM=1instead). Renamedcomp_mptocmp_mp, flipped every call to(cmp, ref)order.Same object-dtype situation as
test_aamp.py:naive.aamp(...)mixes a float distance column with an int index column, so full-array and[:, 0]-sliced comparisons both needed afloat64cast. A few call sites usedecimal=config.STUMPY_TEST_PRECISION— kept those as a config reference rather than the1.5e-07literal. Severalpd.Seriesvariants are commented out in the original file; updated their syntax too but left them commented.37/37 passing under CUDA simulation (matches how
test.sh coverageactually exercises this file).To Do List
assert_almost_equal->assert_allclosertol=0actual, desiredorderatol=1.5e-07literal where nodecimal=was set;config.STUMPY_TEST_PRECISIONreference kept where it wascmpnotcompref_/cmp_naming,.astype(np.float64)cast where the source isdtype=objectPull Request Checklist
black(i.e.,python -m pip install blackorconda install -c conda-forge black)flake8(i.e.,python -m pip install flake8orconda install -c conda-forge flake8)pytest-cov(i.e.,python -m pip install pytest-covorconda install -c conda-forge pytest-cov)black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./in the root stumpy directoryflake8 --extend-exclude=.venv ./in the root stumpy directory./setup.sh dev && ./test.shin the root stumpy directory and ensured that all tests are passing locallyPlease do not commit any code to avoid/circumvent a failing test and, instead, engage in a discussion (below) to determine the best course of action.
Only request a review after the checklist above is fully completed!