Migrate tests/test_floss.py to npt.assert_allclose - #1189
Open
viknesh-ai wants to merge 1 commit into
Open
Conversation
|
Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1189 |
Contributor
Author
|
@seanlaw next file in the split — same conventions as the previous PRs. Ready for review whenever you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1175
Covers
tests/test_floss.py(26 call sites). Renamedcomptocmp, flipped every call to(cmp, ref)order.Only two of the four values compared per site needed a
float64cast:ref_P/ref_Icome from slicingstump()/aamp()output, which isdtype=object(mixes the distance and index columns), same issue as the earlier files.ref_cac_1dandref_Tare already clean, so those stayed uncast.12/12 passing locally in both normal and CI-equivalent (JIT-disabled, CUDA-simulated) modes.
To Do List
assert_almost_equal->assert_allclosertol=0actual, desiredorder (cmp first, ref second)atol=1.5e-07literal - nodecimal=/config references in this filecmpnotcompref_/cmp_naming, casted only where the source is genuinelydtype=objectPull Request Checklist
black(i.e.,python -m pip install blackorconda install -c conda-forge black)flake8(i.e.,python -m pip install flake8orconda install -c conda-forge flake8)pytest-cov(i.e.,python -m pip install pytest-covorconda install -c conda-forge pytest-cov)black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./in the root stumpy directoryflake8 --extend-exclude=.venv ./in the root stumpy directory./setup.sh dev && ./test.shin the root stumpy directory and ensured that all tests are passing locallyPlease do not commit any code to avoid/circumvent a failing test and, instead, engage in a discussion (below) to determine the best course of action.
Only request a review after the checklist above is fully completed!