-
Notifications
You must be signed in to change notification settings - Fork 0
fix(config): keep embedded-constructed structs constructible (un-break coordinode) #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+79
−8
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| //! Guards the embedded-construction contract. | ||
| //! | ||
| //! Downstream products embed the proxy by building a [`ProxyConfig`] | ||
| //! programmatically (runtime upstream port, listen address, baked-in | ||
| //! descriptors) rather than loading a YAML file. This test lives in a separate | ||
| //! crate, so it sees the config types exactly as an external consumer does: if | ||
| //! any wiring struct gains `#[non_exhaustive]`, this stops compiling and the | ||
| //! embedded API regression is caught here. | ||
|
|
||
| use structured_proxy::config::{ | ||
| DescriptorSource, ListenConfig, ProxyConfig, ServiceConfig, UpstreamConfig, | ||
| }; | ||
| use structured_proxy::ProxyServer; | ||
|
|
||
| #[test] | ||
| fn embedded_config_is_constructible() { | ||
| static DESCRIPTOR_BYTES: &[u8] = &[]; | ||
| let config = ProxyConfig { | ||
| upstream: UpstreamConfig { | ||
| default: "http://127.0.0.1:50051".into(), | ||
| }, | ||
| descriptors: vec![DescriptorSource::Embedded { | ||
| bytes: DESCRIPTOR_BYTES, | ||
| }], | ||
| listen: ListenConfig { | ||
| http: "0.0.0.0:8080".into(), | ||
| }, | ||
| service: ServiceConfig { | ||
| name: "embedded-test".into(), | ||
| }, | ||
| aliases: vec![], | ||
| openapi: None, | ||
| auth: None, | ||
| shield: None, | ||
| oidc_discovery: None, | ||
| maintenance: Default::default(), | ||
| cors: Default::default(), | ||
| logging: Default::default(), | ||
| metrics_classes: vec![], | ||
| // Arbitrary: this test only exercises that the config is constructible, | ||
| // not header forwarding. NOTE for real embeddings: a programmatic literal | ||
| // bypasses the serde defaults, so set every header you need here (or load | ||
| // the config via from_file / from_yaml_str, where the default list applies). | ||
| forwarded_headers: vec!["authorization".into()], | ||
| }; | ||
| // The server accepts a programmatically-built config (the embedded path). | ||
| let _server = ProxyServer::from_config(config); | ||
| } | ||
|
|
||
| #[test] | ||
| fn from_yaml_str_loads_config() { | ||
| let config = ProxyConfig::from_yaml_str( | ||
| r#" | ||
| upstream: | ||
| default: "http://127.0.0.1:50051" | ||
| descriptors: | ||
| - file: "/x.bin" | ||
| service: | ||
| name: "yaml-test" | ||
| "#, | ||
| ) | ||
| .unwrap(); | ||
| assert_eq!(config.service.name, "yaml-test"); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.