Skip to content

Add agent 3DS handling #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericgan-stripe wants to merge 2 commits into
base: kreese/ucp-checkout-commands
Choose a base branch
from
Open

Add agent 3DS handling #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9008a59
Add UCP checkout state retrieval
ericgan-stripe Sep 10, 2026
8273f4f
Fix lint errors
ericgan-stripe Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 102 additions & 1 deletion packages/cli/src/__tests__/cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3172,7 +3172,7 @@ describe('production mode', () => {
it('POSTs profile_id and parsed line items to /ucp/checkout', async () => {
setNextResponse(200, {
id: 'dcs_1',
status: 'requires_payment',
status: 'open',
currency: 'usd',
amount_total: 5500,
});
Expand Down Expand Up @@ -3364,5 +3364,106 @@ describe('production mode', () => {
expect(requests).toHaveLength(0);
});
});

describe('checkout retrieve', () => {
it('GETs the composite state once and preserves next_action output', async () => {
setNextResponse(200, {
id: 'dcs_1',
status: 'requires_action',
spend_request: {
id: 'lsrq_1',
status: 'requires_action',
created_at: '2026-03-10T00:00:00Z',
updated_at: '2026-03-10T00:00:01Z',
status_details: {
requires_action: {
next_action: {
type: 'three_d_secure',
resolution: 'auto_resume',
display_message: 'Complete verification',
action_url: 'https://example.com/action',
},
},
},
},
});

const result = await runProdCli(
'ucp',
'checkout',
'retrieve',
'dcs_1',
'--spend-request-id',
'lsrq_1',
'--test',
'--json',
);

expect(result.exitCode).toBe(0);
expect(requests).toHaveLength(1);
expect(lastRequest.method).toBe('GET');
expect(lastRequest.body).toBe('');
const requestUrl = new URL(lastRequest.url, 'http://localhost');
expect(requestUrl.pathname).toBe('/ucp/checkout/dcs_1');
expect(requestUrl.searchParams.get('spend_request_id')).toBe('lsrq_1');
expect(requestUrl.searchParams.get('test')).toBe('true');

const output = parseJson(result.stdout) as Record<string, unknown>;
expect(output).toMatchObject({
id: 'dcs_1',
status: 'requires_action',
spend_request: {
id: 'lsrq_1',
status_details: {
requires_action: {
next_action: {
type: 'three_d_secure',
resolution: 'auto_resume',
display_message: 'Complete verification',
action_url: 'https://example.com/action',
},
},
},
},
});
});

it.each([
[
'a missing checkout ID',
['ucp', 'checkout', 'retrieve', '--spend-request-id', 'lsrq_1'],
],
[
'an empty checkout ID',
['ucp', 'checkout', 'retrieve', '', '--spend-request-id', 'lsrq_1'],
],
[
'a missing spend request ID',
['ucp', 'checkout', 'retrieve', 'dcs_1'],
],
[
'an empty spend request ID',
['ucp', 'checkout', 'retrieve', 'dcs_1', '--spend-request-id', ''],
],
[
'--timeout without --poll',
[
'ucp',
'checkout',
'retrieve',
'dcs_1',
'--spend-request-id',
'lsrq_1',
'--timeout',
'10',
],
],
])('rejects %s without making a request', async (_, args) => {
const result = await runProdCli(...args, '--json');

expect(result.exitCode).toBe(1);
expect(requests).toHaveLength(0);
});
});
});
});
Loading
Loading