Repository navigation
Fix installation support, project isolation, and public-header checks - #47
Conversation
Clarify separate dependency installation and remove the mixed-export workaround. Install project license files, isolate dependency mappings, and scope package version overrides to their owning projects. Fixes #42 Fixes #43 Fixes #44 Fixes #45 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sean-parent
left a comment
There was a problem hiding this comment.
Talos review: no actionable findings
Reviewed commit: f5eafbfcaf488ed47e9107115341330d75875094 against origin/main at df18f94c816df6dc4fbab8078e6b57a7d265a2c2.
All six baseline personas returned zero observations. The required challenge step completed with zero accepted or rejected findings. Accepted: 0; posted inline: 0; overflow/unanchored findings: 0. This is a comment review, not an approval.
| Files | Reviewers | Candidates → validated → accepted | Shown | Tests |
|---|---|---|---|---|
| 23 | 6 personas + challenge | 0 → 0 → 0 | 0 of 0 | All 11 CMake script suites in the PR test plan passed freshly on macOS; whitespace and preset JSON checks passed. |
Coverage includes security, correctness, standards, architecture, operations, and documentation. Base-revision rules loaded: CLAUDE.md and .github/copilot-instructions.md (all 23 changed paths; no instruction diagnostics). No active OpenSpec changes were found.
One pre-existing fatal-error test remains explicitly skipped by the dependency harness. Linux CI, Windows/MSVC DLL deployment, and other hosted variants were not run locally; this review does not certify those results.
Persona routing: static roster (DCAP routing off; rerun with --dcap to enable).
Org knowledge: off (rerun with --knowledge).
Scout
Used: risk MEDIUM, evidence LOW, status COMPLETE (scout 0.9.135, <1s).
Cross-file leads given to reviewers: 0 changed symbol(s) with uses outside the diff, 0 new value(s) not handled everywhere, 0 possibly unused symbol(s).
Scout rated its evidence LOW for this change; reviewers used it only as leads.
Scout evidence is incomplete (rows cut by the packet budget); reviewers treated missing evidence as unknown, not as proof.
Tests to run (Scout: 7 Must Run test(s), in these files):
tests/install/fixtures/consumer/examples/example.cpptests/install/fixtures/consumer/tests/consumer.cpptests/install/README.mdtests/install/fixtures/nested/include/stlab/parent.hpp
These are fixture/documentation locations rather than standalone test commands. The existing nested-install and packaging suites exercised the fixture paths; documentation was reviewed as prose. No extra installed-package consumption suite was added.
Read the component registry before clearing it, with a consecutive-case regression that reproduces stale component leakage. Include the pending source-backed Scout knowledge. Fixes #49 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use CMake's native file-set verification in normal top-level builds when BUILD_TESTING is enabled. Cover C++17, C++20, C++23, later-added and generated headers, public usage requirements, guarded headers, and consumer scope in Linux and Windows CI. Fixes #50 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a linked quick reference and dependency-tracking API entry. Document PowerShell command forms and verify scaffolding in Windows CI. Explain mandatory header checks and preprocessor-guarded no-op headers instead of platform exclusions. Fixes #48 Fixes #53 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Address the final review's two provenance findings by pointing installation and version knowledge at the corresponding current README sections. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sean-parent
left a comment
There was a problem hiding this comment.
Local pre-flight review
No remaining findings. Six Talos personas reviewed the complete branch
against origin/main, followed by the challenge reviewer. Two LOW-priority
Scout citation findings were accepted, fixed, and verified by the documentation
reviewer.
Implementation review: df18f94c816df6dc4fbab8078e6b57a7d265a2c2...cd4cc083a8103c7146a3773e608f56338ac88b82.
The only subsequent delta is three corrected README source ranges in two
knowledge pages, verified at final head
798210fceef3c7fa49a0f7821f6c9a89801f5e05.
| Files | Reviewers | Candidates → validated → accepted | Shown | Tests |
|---|---|---|---|---|
| 29 | 6 personas, challenge | 2 → 2 → 2 LOW, both resolved | 2 of 2 | Mapping: 41 cases/53 assertions; provider merge; 10 header cases; target types; runtime DLLs; clangd; PowerShell scaffold; YAML, README links, JSON presets, whitespace |
Resolved LOW findings
| # | Location | Issue | Fix | Source |
|---|---|---|---|---|
| 1 | .scout/memory/knowledge/installation-supports-separately-installed-dependencies-not-mixed-source-export-workarounds.md:11 |
README additions shifted installation citations into unrelated examples. | Updated to installation guidance at README lines 215–226 and 240–245. | documentation |
| 2 | .scout/memory/knowledge/version-overrides-must-not-leak-into-independently-named-subprojects.md:12 |
The version citation pointed to DLL guidance after README additions. | Updated to version guidance at README lines 769–790. | documentation |
Security, correctness, standards, architecture, and operations returned no
findings. Documentation returned no remaining findings after the citation fixes.
No additional installed-package consumption suite was added.
Base-revision context: CLAUDE.md and the applicable repository-wide
.github/copilot-instructions.md; no context files were capped or skipped.
Hosted platform results are recorded in the PR's CI checks.
Persona routing: static roster (DCAP routing off; rerun with --dcap to enable).
Org knowledge: off (rerun with --knowledge).
Scout
Used: risk MEDIUM, evidence LOW, status COMPLETE (scout 0.9.135, 1s).
Cross-file leads given to reviewers: 0 changed symbol(s) with uses outside the diff, 0 new value(s) not handled everywhere, 0 possibly unused symbol(s).
Scout rated its evidence LOW for this change; reviewers used it only as leads.
Scout evidence is incomplete (rows cut by the packet budget); reviewers treated missing evidence as unknown, not as proof.
Tests to run (Scout: 7 Must Run test(s), in these files):
tests/install/fixtures/consumer/examples/example.cpptests/install/fixtures/consumer/tests/consumer.cpptests/install/README.mdtests/install/fixtures/nested/include/stlab/parent.hpp
These are fixture/document paths, not standalone commands; the existing
installation regression harnesses cover the fixtures.
Summary
INSTALL_OPTIONuse. Libraries must not predeclare shared namespace installation defaults.LICENSEand explicitLICENSE_FILES, with missing-file and installed-name collision checks.BUILD_INTERFACEdependency extraction.BUILD_TESTINGbuilds, using native CMake verification. Support configured C++17/20/23, generated headers, and later-added file sets. Document guarded no-op platform headers instead of exclusion lists.Fixes #42
Fixes #43
Fixes #44
Fixes #45
Fixes #48
Fixes #49
Fixes #50
Fixes #53
Compatibility
Install dependencies separately and let CPM resolve those installed packages.
Source-only builds should disable installation rather than wrap ordinary public
links in
BUILD_INTERFACEto work around exports. Package managers overridingnested project versions must use
CPP_LIBRARY_VERSION_<PROJECT_NAME>.Top-level test builds now require public headers to compile independently.
Headers unavailable for the configured target must guard their contents with the
C++ preprocessor and otherwise be no-ops, optionally including a configuration
header. Source consumption as a subproject does not acquire these checks.
Issues #35 and #36 were already fixed on main by 36d5e2a, merged in #40; both were
verified, commented on, and closed separately. The early installation initializer
in #37 was explained and closed as not planned because its motivating combined
source/dependency installation workflow is outside this installation guidance.
Validation
Local macOS validation used CMake 4.5.0, Ninja 1.13.2, AppleClang 21, clangd 21,
Doxygen 1.18.0, and PowerShell 7.
git diff --check.798210f, including Linux and Windows/MSVC header checks and native Windows PowerShell scaffolding.No additional installed-package consumption suite was added beyond cpp-library's
existing coverage.
Generated with GitHub Copilot CLI