Repository navigation
Add nominal record adapter support - #8
Merged
Merged
Conversation
Add cel::record_adapter<T> and route native typing/value conversion and typed execution through adapter-aware boundaries. Add value and segment tests for nominal-record round-trip, schema checks, typed callback execution, and exception-safe suffix cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reject nominal adapter encodings and write destinations unless descriptors are fully compatible, not just shape-equal. Add a regression test that reproduces same-shape ownership mismatch and asserts rejection before transfer with safe cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sean-parent
commented
Nov 17, 2026
sean-parent
left a comment
Member
Author
There was a problem hiding this comment.
Talos pre-flight review
Verdict: No issues found on this head. Reviewed commit: e67c9d5793367b7f5b6f0deaba1ca43b57e40933. Accepted/posted: 0/0. Overflow: none.
| Files | Reviewers | Candidates → validated → accepted | Shown | Tests |
|---|---|---|---|---|
| 12 | 6 personas, challenge | 0 → 0 → 0 | 0 of 0 | CMake test suite (20/20); clang-tidy preset (20/20); default build/install/package artifact check; documentation build |
Limitations: Hosted CI checks are pending. The release-only docs workflow is skipped for this pull request. Scout evidence was incomplete and was used only as cross-file leads; reviewers treated missing evidence as unknown.
Persona routing: static roster (DCAP routing off; rerun with --dcap to enable).
Org knowledge: off (rerun with --knowledge).
Scout: Used for cross-file leads only. Its review packet was incomplete, so absent leads were not treated as evidence of no impact.
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cmake --preset=test && cmake --build --preset=test && ctest --preset=test— 20/20 passed.cmake --preset=clang-tidy && cmake --build --preset=clang-tidy && ctest --preset=clang-tidy— 20/20 passed.cmake --preset=default && cmake --build --preset=default, then install and package-artifact check with an absolute prefix — passed.cmake --preset=docs && cmake --build --preset=docs— passed.Generated with GitHub Copilot CLI