Skip to content

Add nominal record adapter support - #8

Merged
sean-parent merged 3 commits into
mainfrom
cel-euclid-record-adapter
Nov 18, 2026
Merged

sean-parent merged 3 commits into
mainfrom
cel-euclid-record-adapter

Conversation

@sean-parent

Copy link
Copy Markdown
Member

Summary

  • Add a generic nominal-record adapter to the runtime's typed value and operation boundaries.
  • Validate full schema and ownership compatibility before converting or transferring canonical record storage.
  • Add adapter tests and document the public customization point.

Test plan

  • cmake --preset=test && cmake --build --preset=test && ctest --preset=test — 20/20 passed.
  • cmake --preset=clang-tidy && cmake --build --preset=clang-tidy && ctest --preset=clang-tidy — 20/20 passed.
  • cmake --preset=default && cmake --build --preset=default, then install and package-artifact check with an absolute prefix — passed.
  • cmake --preset=docs && cmake --build --preset=docs — passed.
  • CI-only platform matrix (Ubuntu GCC, Ubuntu Clang, macOS, Windows) — pending.

Generated with GitHub Copilot CLI

sparent_adobe and others added 3 commits November 17, 2026 11:29
Add cel::record_adapter<T> and route native typing/value conversion and typed execution through adapter-aware boundaries. Add value and segment tests for nominal-record round-trip, schema checks, typed callback execution, and exception-safe suffix cleanup.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reject nominal adapter encodings and write destinations unless descriptors are fully compatible, not just shape-equal. Add a regression test that reproduces same-shape ownership mismatch and asserts rejection before transfer with safe cleanup.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@sean-parent sean-parent left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talos pre-flight review

Verdict: No issues found on this head. Reviewed commit: e67c9d5793367b7f5b6f0deaba1ca43b57e40933. Accepted/posted: 0/0. Overflow: none.

Files Reviewers Candidates → validated → accepted Shown Tests
12 6 personas, challenge 0 → 0 → 0 0 of 0 CMake test suite (20/20); clang-tidy preset (20/20); default build/install/package artifact check; documentation build

Limitations: Hosted CI checks are pending. The release-only docs workflow is skipped for this pull request. Scout evidence was incomplete and was used only as cross-file leads; reviewers treated missing evidence as unknown.

Persona routing: static roster (DCAP routing off; rerun with --dcap to enable).

Org knowledge: off (rerun with --knowledge).

Scout: Used for cross-file leads only. Its review packet was incomplete, so absent leads were not treated as evidence of no impact.

@sean-parent
sean-parent merged commit 2dd73e9 into main Nov 18, 2026
6 checks passed
@sean-parent
sean-parent deleted the cel-euclid-record-adapter branch November 18, 2026 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants