Skip to content

Make ownership traversal linear and memoize checked comparisons - #6

Merged
sean-parent merged 1 commit into
mainfrom
worktree-issue-5
Nov 14, 2026
Merged

sean-parent merged 1 commit into
mainfrom
worktree-issue-5

Conversation

@sean-parent

@sean-parent sean-parent commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Replace repeated ownership-root searches with immutable, reusable ranges and a fixed-capacity cursor. Collapse unary paths and visit the largest subrange last to preserve linear traversal and metadata with stack-bounded retirement.
  • Reuse successful descriptor-pair checks across each checked operation, with separate semantic-shape and ownership-operation caches and retained descriptor lifetimes.
  • Add direct traversal, metadata-size, comparison-work, copy-isolation, and partial-cleanup regressions. Preserve standard allocation functions; no global allocation overrides.
  • Simplify complexity contracts to value area plus the distinct-pair comparison bound.

Fixes #5.

Test plan

Fresh local validation on macOS arm64 with AppleClang 21, CMake 4.4.5, Clang-Tidy/clang-format 23.1.5, and Doxygen 1.18.0. All checks cover the contents committed as 6fb19768e224b4f90452b8ffd9e55cd7f45ca24e; no validation cache was reused.

  • cmake --preset test && cmake --build --preset test && ctest --preset test --no-tests=error: 20/20 passed.
  • cmake --preset clang-tidy && cmake --build --preset clang-tidy && ctest --preset clang-tidy --no-tests=error: full static analysis and 20/20 tests passed.
  • cmake -S . -B build/release -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=ON && cmake --build build/release && ctest --test-dir build/release --output-on-failure --no-tests=error: 20/20 passed.
  • cmake --preset docs && cmake --build --preset docs: strict Doxygen passed.
  • Configure/build build/sanitized with -fsanitize=address,undefined -fno-omit-frame-pointer and matching linker flags, then ASAN_OPTIONS=detect_leaks=0 UBSAN_OPTIONS=halt_on_error=1 ctest --test-dir build/sanitized --output-on-failure --no-tests=error: 20/20 passed. macOS LeakSanitizer is unsupported and was not claimed as passed.
  • clang-format --dry-run --Werror on all eight changed C++ files; git diff --check.
  • Mutation-check the comparison regression: disabling memo reuse fails at 32,768 comparisons against a bound of 258; restoring reuse passes.
  • Remote CI run 43544721249: Ubuntu GCC, Ubuntu Clang, macOS, Windows, and Ubuntu Clang-Tidy passed at the exact PR head, including installation/package checks. The release-only documentation deployment job was correctly skipped.

Each local CTest run includes compile-fail gates, deep executable retirement, the runnable example, and installed/source consumer integration tests. Allocation-free traversal is verified from the cursor's fixed storage and transitions, not through global allocation interception.

Generated with GitHub Copilot CLI

Compile reusable ownership ranges, scan them with a fixed-capacity cursor, and reuse successful shape and ownership comparisons throughout checked operations. Add direct work-count regressions without replacing global allocation functions and simplify the complexity contracts.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@sean-parent sean-parent left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talos Review Complete

Verdict: No issues found. This is a comment review, not an approval.

Reviewed commit: 6fb19768e224b4f90452b8ffd9e55cd7f45ca24e against main (merge base f56e206a103c5fbd3486b27efadc24172da6bb84). The local working tree was clean and the PR head was rechecked immediately before publication.

Files Reviewers Candidates -> validated -> accepted Shown Tests
8 of 8 6 personas plus challenge 0 -> 0 -> 0 0 of 0 20/20 CTests each in Debug, Release, Clang-Tidy and ASan/UBSan; strict Doxygen, formatting and whitespace checks passed

Publication counts: 0 accepted findings, 0 inline comments, 0 unanchored findings, 0 overflow. No existing findings required duplicate suppression. Security, correctness, standards, architecture, operations and documentation reviews all completed; the challenge pass accepted 0 and rejected 0 candidates.

Persona routing: static roster (DCAP routing off; rerun with --dcap to enable). Reviewer models follow host-configured defaults.

Org knowledge: off (rerun with --knowledge). No applicable project-rule files, GitHub custom instructions or active OpenSpec changes were found at the base revision.

Scout

Scout 0.9.135 was used as supplemental evidence: risk CRITICAL, evidence LOW, status INCOMPLETE. Those are packet-level heuristics, not accepted review findings. Cross-file leads covered 3 changed symbols with uses outside the diff, 0 new values not handled everywhere, and 1 possibly unused symbol.

Scout's evidence was incomplete: bounded change analysis, rows cut by the packet budget, truncated dead-code candidates, and 30 omitted affected-test entries (24 Must Run and 6 Should Run). Six changed files used conservative whole-file roots. Reviewers treated missing evidence as unknown and supplemented the packet with the complete eight-file diff and targeted source reads.

Verification limitations

Local validation was on macOS arm64 with AppleClang 21. All configured tests, including compile-fail gates, deep retirement, the runnable example and installed/source consumers, ran in each of the four configurations. The comparison-work regression was mutation-checked. Global allocation functions were not replaced; allocation-free traversal is verified from fixed cursor storage and nonallocating transitions, not allocation interception. Unsupported macOS LeakSanitizer was disabled, not claimed as passed. Remote Ubuntu GCC/Clang, Windows, macOS and Ubuntu Clang-Tidy CI remain separate checks.

Generated with GitHub Copilot CLI using the local Talos persona/challenge workflow.

@sean-parent
sean-parent merged commit d9e7488 into main Nov 14, 2026
6 checks passed
@sean-parent
sean-parent deleted the worktree-issue-5 branch November 14, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make value ownership traversal linear and memoize checked-operation compatibility

1 participant