Skip to content

Upgrade cpp-library to 6.1.0 and simplify CMake setup - #10

Merged
sean-parent merged 2 commits into
mainfrom
build/cpp-library-6.1-cleanup
Nov 19, 2026
Merged

sean-parent merged 2 commits into
mainfrom
build/cpp-library-6.1-cleanup

Conversation

@sean-parent

@sean-parent sean-parent commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Summary

Test plan

Fresh validation on macOS with AppleClang 21.0.0, CMake/CTest 4.5.0, and clang-format/clang-tidy 23.1.5:

  • clang-format --dry-run --Werror over all existing tracked C++ headers and sources; git diff --check.
  • cmake --preset test, cmake --build --preset test, ctest --preset test --no-tests=error: 18/18 tests, including compile-fail checks; independent compilation of all 11 public headers.
  • cmake --preset clang-tidy, cmake --build --preset clang-tidy, ctest --preset clang-tidy --no-tests=error: 18/18 tests and no lint/build warnings.
  • Fresh session-local Release configure (-DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=ON), build, and ctest --test-dir ... --output-on-failure --no-tests=error: 18/18 tests.
  • Fresh session-local Debug ASan/UBSan configure (-fsanitize=address,undefined -fno-omit-frame-pointer), build, and CTest with ASAN_OPTIONS=detect_leaks=0 UBSAN_OPTIONS=halt_on_error=1: 18/18 tests. LeakSanitizer is unsupported on this macOS host and was not claimed as passing.
  • cmake --preset docs, cmake --build --preset docs: strict Doxygen generation without the removed source-copy hook.
  • cmake --preset default, cmake --build --preset default, installation into an isolated session-local prefix, and the generated cpp-library-test-package.cmake artifact check: pass.
  • Hosted CI at 1c297ea456f24bc9640650bed4dc2a4b677de3b3: Ubuntu GCC, Ubuntu Clang, macOS, Windows, and Ubuntu clang-tidy each ran and passed 18 tests. Build/install/package-artifact checks passed on all four platform jobs. The release-only Pages job was correctly skipped for this PR; documentation was built locally.

The Release and sanitizer builds used fresh session-local directories because the old build caches refer to the checkout's former location. Complete local logs contain no warnings or errors. No persistent validation cache was reused or written for the initially dirty tree.

Generated with GitHub Copilot CLI

sean-parent and others added 2 commits November 18, 2026 19:30
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Upgrade cpp-library to 6.1.0 and regenerate its templates. Remove redundant documentation copying and settings, project-specific consumer tests and fixtures, and local test timeout policy. Retain private test-header access and portable thread linkage pending stlab/cpp-library#57; centralized time limits are tracked in stlab/cpp-library#56.

Fixes #9.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@sean-parent sean-parent left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talos local review

Verdict: No actionable findings after the six-persona review and mandatory challenge step.

Reviewed commit: 1c297ea456f24bc9640650bed4dc2a4b677de3b3
Scope: full PR diff against origin/main, merge base e47232f8ed6cb83bc11f4cb418a8a2249c2415cf.

Files Reviewers Candidates → validated → accepted Shown Tests
13 6 personas + challenge 0 → 0 → 0 0 of 0 18/18 locally in Debug, Release, clang-tidy, and ASan/UBSan; 18/18 in each hosted test job

Security, correctness, standards, architecture, operations, and documentation reviewers each read the complete 455-line diff. The two generated preset/task descriptions are not actionable finding targets. No persona failed. No project rule files, applicable GitHub custom instructions, or active OpenSpec specs were present at the base.

Publication counts: 0 accepted findings, 0 inline comments posted, 0 overflow findings, and no existing findings to duplicate. This is a comment review, not an approval.

Verification: Full C++ formatting check, all 11 independent public-header checks, strict Doxygen generation without the deleted source-copy hook, installation, and the generated package-artifact check passed. Hosted CI passed at this exact head: Ubuntu GCC, Ubuntu Clang, macOS, Windows, and Ubuntu clang-tidy each ran 18 tests; platform install/package-artifact checks also passed. The release-only Pages job was skipped as configured. macOS LeakSanitizer was unsupported and disabled, not claimed as passing.

Persona routing: static roster (DCAP routing off; rerun with --dcap to enable).

Org knowledge: off (rerun with --knowledge).

Scout

Used: risk HIGH, evidence LOW, status COMPLETE (scout 0.9.135, 1s).
Cross-file leads given to reviewers: 4 changed symbol(s) with uses outside the diff, 0 new value(s) not handled everywhere, 3 possibly unused symbol(s).
Scout rated its evidence LOW for this change; reviewers used it only as leads.
Scout evidence is incomplete (rows cut by the packet budget); reviewers treated missing evidence as unknown, not as proof.

Scout reported 27 Must Run and 24 Should Run affected-test entries, but omitted 55 entries from its bounded packet. This does not establish exhaustive affected-test coverage; the complete configured runtime suite was run independently in all four local configurations and all five hosted test jobs.

@sean-parent
sean-parent merged commit a819042 into main Nov 19, 2026
6 checks passed
@sean-parent
sean-parent deleted the build/cpp-library-6.1-cleanup branch November 19, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid attaching docs commands to a parent project target

1 participant