Repository navigation
Support nominal records and floating-literal parity - #2
Conversation
Add op_lookup::register_record_type<T>() that installs the complete nominal descriptor from record_adapter<T>::type(), with nominal-record validation and existing duplicate/reserved-name behavior. Add lookup and parser tests covering reordered record literal receiver calls, same-layout nominal separation, duplicate nominal identity rejection, record field compile failures, and unsupported nominal operand callback non-invocation. Update parser library docs and pin the runtime CPM dependency to commit e67c9d5793367b7f5b6f0deaba1ca43b57e40933. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Snapshot the nominal identity before moving the descriptor and apply clang-format to the new adapter tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sean-parent
left a comment
There was a problem hiding this comment.
Talos review
Verdict: One low-severity finding. Reviewed commit 338d124211e601f440706c4b92a99f2a1994a3c1 against main with six personas and a challenge pass.
Findings: 1 accepted, 1 posted inline, 0 overflow.
Verification: The test and clang-tidy presets each passed 19/19 tests; the documentation build and changed-file clang-format check passed. Scout evidence was incomplete, so reviewers did not treat missing leads as proof of absence. Org knowledge was not enabled.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sean-parent
left a comment
There was a problem hiding this comment.
Talos review
Verdict: Needs attention: one High and one Medium finding. Reviewed the parser PR delta from last reviewed head 338d124 through 6eb5ba5; the additional dependency-release commit received a separate six-persona pass.
Findings: 2 accepted, 2 posted inline, 0 overflow. The challenge pass rejected one performance observation as within the documented complexity contract.
Coverage: 16 changed files; six static personas and the challenge reviewer; 7 candidates, 7 validated, 2 accepted.
Verification: cmake --build --preset=test and ctest --preset=test passed (21/21); cmake --build --preset=clang-tidy and ctest --preset=clang-tidy passed (22/22). The first configure hit stale CPM_DIRECTORY; clearing that cache entry allowed configuration. Current-head CI passed Ubuntu GCC/Clang, macOS, Windows, and clang-tidy; docs was skipped.
Limitations: Scout evidence for the 16-file delta was incomplete because its packet truncated rows and dead-code candidates. Org knowledge was off.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Require the integer-form float and exponent-sign fixes before the parity gate invokes Cargo. Clarify parse_str numeric forms and include the requested local memory updates.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
cpp-library tracks cel-runtime 1.1.0 from CPM and infers find_dependency(cel-runtime 1.1.0). Verify the generated installed package config without an explicit mapping.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sean-parent
left a comment
There was a problem hiding this comment.
Review the use of cpp-library and the changes in 6.0. This looks like the dependency was updated without considering the changes in a breaking release.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Reviewed the cpp-library 6.0 changes. I removed the redundant explicit C++20 requirement and Doxygen strip-path overrides; cpp-library 6 supplies those defaults, and the documentation build passed. I retained the explicit runtime dependency map because a fresh configure without it failed to track |
sean-parent
left a comment
There was a problem hiding this comment.
Talos review
Verdict: No new findings on final head 2bb3d71. The previously identified mutable-tag supply-chain issue is fixed: cel-runtime is pinned to commit 2dd73e9c26c6d02c79bfb26f82521c62a1bfd079 while package compatibility remains 1.1.0.
Findings: 0 accepted, 0 posted inline.
Coverage: Reviewed the full 27-file PR diff against main and the four-file delta since the previously pushed head. Five static personas returned usable results; the documentation persona did not provide a valid complete review. The challenge pass had no observations to challenge. The full-diff Scout packet was incomplete; the focused four-file delta packet was complete. Org knowledge was off; i18n and test-quality reviewers were not eligible.
Verification: cmake --preset test, cmake --build --preset test, and ctest --preset test passed (21/21), including the installed-consumer test.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary
op_lookup::register_record_type<T>(name)for adapter-backed nominal schemas, separating CEL constructor names from runtime identities and rejecting unspellable nested fields.f64literals such as1f64without adding integer orf32values, and reject exponent signs after underscores.cel-runtime@1.1.1at commite47232f8ed6cb83bc11f4cb418a8a2249c2415cfwith a versioned CPM URI.docs/validation.md.Related work: stlab/cel-rs#292 and stlab/cel-euclid#1.
Test plan
cel-runtime1.1.1 at7abd34f: 18/18 CTest targets.a0a16c7; later commits change only Scout memory files.2bb3d71.Generated with GitHub Copilot CLI