Skip to content

Support nominal records and floating-literal parity - #2

Merged
sean-parent merged 20 commits into
mainfrom
cel-euclid-record-registration
Nov 18, 2026
Merged

sean-parent merged 20 commits into
mainfrom
cel-euclid-record-registration

Conversation

@sean-parent

@sean-parent sean-parent commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Add op_lookup::register_record_type<T>(name) for adapter-backed nominal schemas, separating CEL constructor names from runtime identities and rejecting unspellable nested fields.
  • Accept decimal integer-form f64 literals such as 1f64 without adding integer or f32 values, and reject exponent signs after underscores.
  • Pin cel-runtime@1.1.1 at commit e47232f8ed6cb83bc11f4cb418a8a2249c2415cf with a versioned CPM URI.
  • Adopt cpp-library 6.0.2 automatic dependency tracking for the generated package config.
  • Remove the installed-consumer test. The package check verifies only that the component is installed; installation is not a supported consumption path. See docs/validation.md.

Related work: stlab/cel-rs#292 and stlab/cel-euclid#1.

Test plan

  • Test preset with cel-runtime 1.1.1 at 7abd34f: 18/18 CTest targets.
  • Ubuntu GCC, Ubuntu Clang, macOS, Windows, and clang-tidy GitHub CI at a0a16c7; later commits change only Scout memory files.
  • Talos review of changes since 2bb3d71.

Generated with GitHub Copilot CLI

sparent_adobe and others added 2 commits November 17, 2026 12:07
Add op_lookup::register_record_type<T>() that installs the complete
nominal descriptor from record_adapter<T>::type(), with nominal-record
validation and existing duplicate/reserved-name behavior.

Add lookup and parser tests covering reordered record literal receiver
calls, same-layout nominal separation, duplicate nominal identity
rejection, record field compile failures, and unsupported nominal
operand callback non-invocation. Update parser library docs and pin the
runtime CPM dependency to commit e67c9d5793367b7f5b6f0deaba1ca43b57e40933.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Snapshot the nominal identity before moving the descriptor and apply clang-format to the new adapter tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@sean-parent sean-parent left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talos review

Verdict: One low-severity finding. Reviewed commit 338d124211e601f440706c4b92a99f2a1994a3c1 against main with six personas and a challenge pass.

Findings: 1 accepted, 1 posted inline, 0 overflow.

Verification: The test and clang-tidy presets each passed 19/19 tests; the documentation build and changed-file clang-format check passed. Scout evidence was incomplete, so reviewers did not treat missing leads as proof of absence. Org knowledge was not enabled.

Comment thread tests/lookup_test.cpp Resolved
sparent_adobe and others added 4 commits November 17, 2026 13:14
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@sean-parent sean-parent changed the title Add nominal record adapter registration Support nominal records and floating-literal parity Nov 18, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@sean-parent sean-parent left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talos review

Verdict: Needs attention: one High and one Medium finding. Reviewed the parser PR delta from last reviewed head 338d124 through 6eb5ba5; the additional dependency-release commit received a separate six-persona pass.

Findings: 2 accepted, 2 posted inline, 0 overflow. The challenge pass rejected one performance observation as within the documented complexity contract.

Coverage: 16 changed files; six static personas and the challenge reviewer; 7 candidates, 7 validated, 2 accepted.

Verification: cmake --build --preset=test and ctest --preset=test passed (21/21); cmake --build --preset=clang-tidy and ctest --preset=clang-tidy passed (22/22). The first configure hit stale CPM_DIRECTORY; clearing that cache entry allowed configuration. Current-head CI passed Ubuntu GCC/Clang, macOS, Windows, and clang-tidy; docs was skipped.

Limitations: Scout evidence for the 16-file delta was incomplete because its packet truncated rows and dead-code candidates. Org knowledge was off.

Comment thread tools/parity/core_corpus.py Resolved
Comment thread src/compiler.cpp Resolved
sparent_adobe and others added 3 commits November 17, 2026 20:26
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Require the integer-form float and exponent-sign fixes before the parity gate invokes Cargo. Clarify parse_str numeric forms and include the requested local memory updates.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
cpp-library tracks cel-runtime 1.1.0 from CPM and infers find_dependency(cel-runtime 1.1.0). Verify the generated installed package config without an explicit mapping.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@sean-parent sean-parent left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the use of cpp-library and the changes in 6.0. This looks like the dependency was updated without considering the changes in a breaking release.

Comment thread CMakeLists.txt Resolved
Comment thread CMakeLists.txt Resolved
Comment thread CMakeLists.txt Resolved
sparent_adobe and others added 4 commits November 17, 2026 20:59
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@sean-parent

Copy link
Copy Markdown
Member Author

Reviewed the cpp-library 6.0 changes. I removed the redundant explicit C++20 requirement and Doxygen strip-path overrides; cpp-library 6 supplies those defaults, and the documentation build passed. I retained the explicit runtime dependency map because a fresh configure without it failed to track cel::runtime for the installed package config. The generated package then omitted find_dependency(cel-runtime); with the mapping it requires cel-runtime 1.1.0 CONFIG. I also restored the installed-consumer test because cpp-library’s artifact check does not configure a consumer or validate the recursive dependency install closure. That consumer test passes. The runtime is pinned to commit 2dd73e9c26c6d02c79bfb26f82521c62a1bfd079.

@sean-parent sean-parent left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talos review

Verdict: No new findings on final head 2bb3d71. The previously identified mutable-tag supply-chain issue is fixed: cel-runtime is pinned to commit 2dd73e9c26c6d02c79bfb26f82521c62a1bfd079 while package compatibility remains 1.1.0.

Findings: 0 accepted, 0 posted inline.

Coverage: Reviewed the full 27-file PR diff against main and the four-file delta since the previously pushed head. Five static personas returned usable results; the documentation persona did not provide a valid complete review. The challenge pass had no observations to challenge. The full-diff Scout packet was incomplete; the focused four-file delta packet was complete. Org knowledge was off; i18n and test-quality reviewers were not eligible.

Verification: cmake --preset test, cmake --build --preset test, and ctest --preset test passed (21/21), including the installed-consumer test.

sparent_adobe and others added 5 commits November 17, 2026 22:36
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@sean-parent
sean-parent merged commit 74bb4b9 into main Nov 18, 2026
6 checks passed
@sean-parent
sean-parent deleted the cel-euclid-record-registration branch November 18, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants