(Towards #3463) Reverse the order of operations to build the region in reverse#3464
(Towards #3463) Reverse the order of operations to build the region in reverse#3464LonelyCat124 wants to merge 5 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3464 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 395 395
Lines 55199 55200 +1
=========================================
+ Hits 55199 55200 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sergisiso
left a comment
sergisiso
left a comment
There was a problem hiding this comment.
@LonelyCat124 There is a small comment but I am ok with this change and it is already tested by all the maximal_region_trans_test examples. So this can be merged after the release.
| all_blocks = [] | ||
| current_block = [] | ||
| for child in node_list: | ||
| for child in node_list[::-1]: |
There was a problem hiding this comment.
Maybe reversed(node_list) ?
There was a problem hiding this comment.
Yeah this is probably more efficient than making a new list since we don't modify, done.
…Syclone into 3463_reverse_transformation_order
|
@sergisiso This is ready for another look - i couldn't just do reversed without checking I had a list and not a schedule, so I fixed that. |
2 participants
Simple PR to reverse the order in which maximal parallel region trans build their regions. I expect to need this to work out if assignments can be in parallel regions and its probably a more sensible default way to build these regions.
Ready for a review from @arporter or @sergisiso . I considered using a
deque, however I would have ended up needing to cast thedequeto alistenough times I didn't think it would save anything.