docs: collect unreleased maintenance notes - #3488
Conversation
Keep the timestamp fix and dependency updates in one final notes PR, preserving the latest main entries. Land the code and dependency PRs before these notes.
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed September 7, 2026, 11:03 PM ET / September 8, 2026, 03:03 UTC. ClawSweeper reviewWhat this changesAdds Unreleased highlights, Claude measurement-timestamp and Sparkle safety notes, contributor credit, and dependency maintenance versions. Merge readiness⛔ Blocked before merge - 3 items remain Keep open: the notes remain useful, but the previously identified internal-only maintenance bullet still conflicts with release policy. This owner-authored PR is also protected from automatic closure. Priority: P3 Review scores
Verification
How this fits togetherCodexBar’s changelog supplies user-facing notes for GitHub Releases and Sparkle updates. This PR adds prose to the upcoming release section without changing application behavior or publication settings. flowchart LR
A[Implemented changes] --> B[Unreleased changelog]
B --> C[Release preparation]
C --> D[GitHub release notes]
C --> E[Sparkle update notes]
D --> F[Users]
E --> F
Before merge
Findings
Agent review detailsSecurityNone. Review metricsNone. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep concise user-facing timestamp and updater-safety notes, omit internal version bookkeeping, and preserve the owner’s prerequisite landing order. Do we have a high-confidence way to reproduce the issue? Not applicable to runtime reproduction: the documentation defect is directly visible in the introduced bullet and the release-guide contract. Is this the best way to solve the issue? Yes, collecting the notes separately is a narrow solution once the internal-only maintenance bullet is removed and the prerequisite changes land. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 9810f24b0609. LabelsLabel justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
History |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b50b1ddb01
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - Antigravity local usage: tolerate bookkeeping steps without UUIDs while retaining duplicate bot-ID ambiguity checks, so valid history remains available without assigning uncertain dates (#3462). Thanks @urda! | ||
|
|
||
| ### Maintenance | ||
| - Update Commander to 0.2.4, swift-log to 1.15.0, swift-asn1 to 1.7.2, and the pinned checkout action to 7.0.1. |
There was a problem hiding this comment.
The release pipeline embeds this changelog section into Sparkle and GitHub release notes (docs/RELEASING.md:74), while the release checklist explicitly requires user-facing entries and says to omit script bumps (docs/RELEASING.md:110). Commander, swift-log, swift-asn1, and especially the pinned checkout action are implementation/CI maintenance with no user-visible outcome; remove this bullet or describe only an actual user-facing effect.
Useful? React with 👍 / 👎.
|
Validation on
The linked code/dependency changes carry their full local suites and real built-binary/app proofs. #3485 and #3487 are both green and land-ready on their final exact heads. This notes-only change follows the repository’s existing documentation CI path: macOS/musl skip, while both Linux builds and the aggregate remain required. Notes CI passed on the exact head, including both Linux builds and aggregate; macOS/musl skipped under the existing documentation policy. Land #3485, then #3487, then this PR. No tag, version bump or release publication is included. |
clawsweeper
Bot
added
P3
Update Commander, Sparkle, swift-log, swift-asn1 and checkout 7.0.1 within existing major constraints. Sparkle includes installer hardening. Keep release notes in #3488. Closes no issue; no version or publication is included.
1 participant
Collect the user-visible timestamp fix from #3485 and compatible dependency updates from #3487 in one final Unreleased section, with contributor credit and a Highlights lead-in. Preserve the existing main entries, including the newly landed CLI login cancellation fix.
Land #3485, then #3487, then this notes PR. Keeping notes separate prevents unrelated additions to main’s changelog from conflicting with the dependency branch.
Validation: local documentation links and whitespace checks pass; independent P0–P2 review is clean. Released sections are unchanged. The underlying changes have complete local suites, built CLI/native app proof and independent reviews; #3485 and #3487 both have green exact-head CI. This notes-only PR passes its own exact-head CI, including both Linux builds and aggregate; macOS/musl use the documented skip.
This does not change the version, create a tag, or authorize publication. The broader issue/PR queue still needs another bounded pass before release preparation.