Update provider branding color palettes - #3419
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83799f37ae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Codex review: needs maintainer review before merge. Reviewed September 4, 2026, 10:04 AM ET / 14:04 UTC. ClawSweeper reviewWhat this changesThe PR refreshes menu and confetti accent colors across 37 provider descriptors, explicitly retains existing widget colors, and updates the Command Code color regression test. Merge readiness✅ Ready for maintainer review The previously reported widget-palette and Command Code test regressions are resolved at the current PR head. The verified test merge still contains this PR’s 38-file palette update, so the work remains distinct from current main and is ready for normal merge review once checks finish. Priority: P3 Review scores
Verification
How this fits togetherCodexBar provider descriptors supply branding colors to menu usage cards, celebration effects, and widgets. Each descriptor’s branding is read by those UI surfaces, with the widget color intentionally separate from the menu accent. flowchart LR
A[Provider descriptors] --> B[Branding configuration]
B --> C[Menu usage cards]
B --> D[Confetti effects]
B --> E[Widgets]
F[Regression tests] --> B
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Merge the scoped palette refresh with explicit widget-color preservation so menu branding can evolve without changing existing widget visuals. Do we have a high-confidence way to reproduce the issue? Not applicable: the PR updates static visual palette values rather than repairing a reported runtime failure. Is this the best way to solve the issue? Yes. Keeping widgetColor explicit while updating menu and confetti colors follows the shared branding model’s intended separation and preserves the existing widget invariant. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 30f881aee0e8. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
Summary
widgetColorvalues where descriptors previously derived them from the old accent color.0x8C4EDDaccent.Details
A table of updated colors:
#38BDF8#814EE8#E25C2B#C70007#DC2626#F34E3F#6366F1#1AA049#FF9900#01A88D#3184FF#63D297#596EF6#1F5AE0#61A3FA#5487C8#44FF00#00FF95#A04DFD#8C4EDD#A855F7#8534F3#2EAB94#8B7CFF#00BFA5#F54E00#527DF0#4D6BFE#6467F2#13EF93#46B482#317CFF#3370FF#0057FF#F25B1C#6720FF#F56844#F55036#FF3399#955AE0#F27027#FAF74F#FE603C#007CFF#FF9900#9046FF#4C89F0#5B3FD1#FFD100#29E154#FF500F#FF5229#205DEB#000000#38D98C#D55934#337EA9#2EAADC#3B82F6#3B7DD8#20B2AA#20808D#10B981#2ADB5C#2975DB#CC2B2B#2DC6D8#14B8A6#F56647#A3004C#3399FF#3C8FDD#938BB4#01A4FFTesting
make checkpassesswift test --filter MenuCardProviderRegressionTests --filter ProviderArchitectureGatekeeperTestspassesswift test --filter ProviderArchitectureGatekeeperTestspassesScreenshots