Add hover details to inline cost charts - #3413
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs maintainer review before merge. Reviewed September 4, 2026, 2:05 AM ET / 06:05 UTC. ClawSweeper reviewWhat this changesThe PR adds date, localized cost, and token details when hovering inline menu-card cost bars, including selection styling and coverage for calendar, layout, accessibility, and currency behavior. Merge readiness✅ Ready for maintainer review Keep open: current main does not yet provide hover details in inline cost bars, and this focused feature reuses the established native chart-hover pattern with no introduced correctness or security defect found. Priority: P3 Review scores
Verification
How this fits togetherCodexBar converts provider cost and token snapshots into compact inline charts in menu cards. The new interaction maps mouse position over those bars to one daily data point and displays its existing cost/token data in the card. flowchart LR
A[Provider daily cost and token history] --> B[Inline dashboard data]
B --> C[Compact cost bars]
C --> D[Mouse position tracking]
D --> E[Selected daily point]
E --> F[Menu-card detail label]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Land the focused hover interaction if ordinary merge checks remain green, preserving the existing distinction between zero-filled established history and unknown daily data. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR adds a UI capability rather than reporting broken existing behavior; its supplied screenshot and production-view screenshot coverage document the proposed interaction. Is this the best way to solve the issue? Yes. The patch reuses the existing native chart-hover mechanism and daily snapshot model while leaving settings charts and the detailed Cost History submenu unchanged. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 392310c66548. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Summary
Adds a hover preview to inline cost bars in menu cards, showing the date, localized cost, and token count while highlighting the selected bar. Settings charts and the existing Cost History submenu remain unchanged.
Demo
Testing