feat: add CodeRabbit provider support - #3383
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d582df1526
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let primary: RateWindow? = { | ||
| if let periodResets { | ||
| return RateWindow( | ||
| usedPercent: 0, |
There was a problem hiding this comment.
Avoid synthesizing a zero-percent review quota
Whenever the CLI supplies a reset date, this creates a real rate window with usedPercent: 0, even though the parsed review count has no accompanying limit. The normal menu formatter therefore reports “Reviews: 100%” in remaining mode, and the status icon stays completely full regardless of the number of reviews. Keep this reset/count as detail-only data unless the CLI exposes a denominator from which an actual percentage can be calculated.
Useful? React with 👍 / 👎.
|
Codex review: needs real behavior proof before merge. Reviewed September 2, 2026, 3:37 PM ET / 19:37 UTC. ClawSweeper reviewWhat this changesAdds an opt-in first-party CodeRabbit provider that reads local CLI usage and authentication output, displays the parsed review and billing data, and registers its icons, documentation, and tests. Merge readiness⛔ Blocked until stronger real behavior proof is added - 9 items remain Keep open: the new balance-only descriptor makes an existing gatekeeper assertion fail, and the submitted trace does not consistently demonstrate the claimed authenticated CLI path. Priority: P2 Review scores
Verification
How this fits togetherCodexBar provider descriptors turn local provider data sources into shared usage snapshots for the menu-bar app and CLI. This change adds a CodeRabbit CLI probe and parser to that descriptor-driven pipeline. flowchart TD
A[Local CodeRabbit CLI] --> B[Usage and auth-status probe]
B --> C[CodeRabbit output parser]
C --> D[Provider usage snapshot]
D --> E[Provider registry]
E --> F[CodexBar menu and CLI output]
Decision needed
Why: This PR adds a stable provider ID, local executable integration, documentation, and settings exposure; that product-scope choice requires repository-owner intent beyond a mechanical repair. Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: If maintainer direction approves first-party CodeRabbit support, preserve the opt-in default, update the intentional capability registry, and attach a redacted trace from the real local CLI using a format consistent with the command. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR proposes a new provider rather than reporting broken existing behavior; the contributor's claimed real integration trace is insufficient as merge proof. Is this the best way to solve the issue? Unclear: the implementation follows the descriptor architecture, but first-party provider admission needs maintainer direction and the branch must repair its broken gatekeeper invariant. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against acdf208234d5. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (5 earlier review cycles)
|
|
@clawsweeper re-review P2-Finding ist durch den aktuellen Head behoben —
Der P2-Befund aus der vorherigen Runde ist damit am aktuellen Head behoben — der Fix-Commit |
|
🦞👀 Re-review progress:
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
Summary
Adds first-party provider support for CodeRabbit (
coderabbit) in CodexBar.coderabbit usageandcoderabbit auth status.coderabbit auth login(~/.coderabbit/auth.json).ProviderIcon-coderabbit.svgand updated base64 serve icons.docs/coderabbit.md, updateddocs/providers.mdandREADME.md.Tests/CodexBarTests/CodeRabbitUsageParserTests.swift.Test Plan
Scripts/regenerate-provider-manifests.sh checkpassed (70 providers).Scripts/check-documentation-links.mjspassed (192 links OK).Redacted authenticated CLI-to-CodexBar proof (after fix)
Real authenticated flow, observed in CodexBar after the fix (
79fa173fa), captured viacodexbar usage --provider coderabbitwith--format json --pretty:Captured at 2026-09-02T15:23:08Z; the dashboard snapshot reflects the same plan, identity, and billing details. Redacted: no token material is shown.
Naming policy (fixed)
Linux Swift Testing cases now use sentence-style backticked names per the repository convention:
parses standard coderabbit usage textparses coderabbit usage combined with auth status textsigned out output throws notLoggedInempty or invalid output throws parseFailed