Repository navigation
ci: stop passing unused secrets to the shared workflow - #220
Merged
Merged
Conversation
The shared extension workflow logs in to SonarQube Cloud with the job's identity and no longer uses the artifact server login. re 25641
Contributor
|
Claude finished @achoimet's task in 10s —— View job Review of PR #220The diff removes three unused secret pass-throughs (
No changes needed from my side. I made no code changes and ran no tests. |
achoimet
enabled auto-merge (squash)
November 17, 2026 16:12
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Removes secrets that this build still passes to the shared extension workflow, which no longer uses them:
SONAR_TOKEN: the shared workflow logs in to SonarQube Cloud with the job's GitHub identity since feat(ci): SonarQube Cloud analysis without a stored token extension-kit#207. The repository's own token was deleted on 2026-11-17 and the builds have run without it since.STEADYBIT_ARTIFACT_SERVER_USERNAME/_PASSWORD, where present: the shared workflow only declared them, and both organisation secrets are deleted.No behaviour changes: the values passed were already empty. This pull request's own build shows the Sonar login and scan.