Skip to content

ci: stop passing unused secrets to the shared workflow - #220

Merged
achoimet merged 1 commit into
mainfrom
ci/drop-unused-secrets
Nov 17, 2026
Merged

achoimet merged 1 commit into
mainfrom
ci/drop-unused-secrets

Conversation

@achoimet

Copy link
Copy Markdown
Member

Removes secrets that this build still passes to the shared extension workflow, which no longer uses them:

  • SONAR_TOKEN: the shared workflow logs in to SonarQube Cloud with the job's GitHub identity since feat(ci): SonarQube Cloud analysis without a stored token extension-kit#207. The repository's own token was deleted on 2026-11-17 and the builds have run without it since.
  • STEADYBIT_ARTIFACT_SERVER_USERNAME / _PASSWORD, where present: the shared workflow only declared them, and both organisation secrets are deleted.

No behaviour changes: the values passed were already empty. This pull request's own build shows the Sonar login and scan.

The shared extension workflow logs in to SonarQube Cloud with the job's identity and no longer uses the artifact server login.

re 25641
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @achoimet's task in 10s —— View job


Review of PR #220

The diff removes three unused secret pass-throughs (SONAR_TOKEN, STEADYBIT_ARTIFACT_SERVER_USERNAME and STEADYBIT_ARTIFACT_SERVER_PASSWORD) from .github/workflows/ci.yml. The remaining secrets: block is intact and valid YAML.

  • Bugs: I found none. The PR description says the values were already empty, so behaviour doesn't change.
  • Security: Passing fewer secrets to the reusable workflow is a small improvement.
  • Things to check:
    • The reusable workflow is pinned to @main. Before merging, confirm that reusable-extension-ci.yml no longer declares SONAR_TOKEN as required: true. If it did, the call would fail. The PR description says the build shows the Sonar login and scan, so this is probably fine.
    • The Sonar login now uses the job's GitHub identity. That needs id-token: write on the calling job or workflow. I didn't verify that permission in the file, but a passing build would confirm it.
  • Previous review threads: There were none to resolve.

No changes needed from my side. I made no code changes and ran no tests.

@achoimet
achoimet enabled auto-merge (squash) November 17, 2026 16:12
@sonarqubecloud

Copy link
Copy Markdown

@achoimet
achoimet merged commit 61385d0 into main Nov 17, 2026
13 checks passed
@achoimet
achoimet deleted the ci/drop-unused-secrets branch November 17, 2026 16:27
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant