build(workflows): remove orphaned matrix include entries in nightly install tests#13452
Closed
Planeshifter wants to merge 1 commit into
Closed
build(workflows): remove orphaned matrix include entries in nightly install tests#13452Planeshifter wants to merge 1 commit into
include entries in nightly install tests#13452Planeshifter wants to merge 1 commit into
Conversation
… install tests
The jobs `test_install` (`linux_test_install`) and `test_npm_install`
(`macos_test_npm_install`) have failed on every scheduled run on
develop for the past month with:
Error when evaluating 'runs-on' for job 'test_install'.
Unexpected value ''
Root cause: both workflows trim `strategy.matrix.NODE_VERSION` to
`['20', '18', '16']`, but `strategy.matrix.include` still listed
entries for older, no-longer-present versions ('14', '12', '10',
'8', '6', '4', '0.12', '0.10'). Per GitHub Actions matrix semantics,
an `include` entry whose specified keys match no existing base
combination is added as an entirely new combination containing only
the keys given in that entry - leaving `OS` (and thus
`runs-on: ${{ matrix.OS }}`) undefined, which GitHub Actions rejects
at evaluation time before any job runs.
This commit removes the orphaned `include` entries so every
remaining entry matches an existing NODE_VERSION/OS combination,
restoring a defined `matrix.OS` for all generated jobs.
Ref: https://github.com/stdlib-js/stdlib/actions/runs/29241867217
Ref: https://github.com/stdlib-js/stdlib/actions/runs/29241447715
Member
Author
|
Duplicate — #13231 and #13232 already propose this identical fix (split by workflow file), open since 2026-07-02. Closing this in favor of those. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
linux_test_installandmacos_test_npm_installworkflows, which have failed on every scheduled run for the past month ondevelop. Root cause:strategy.matrix.includein both YAML files still listed entries forNODE_VERSIONvalues (14,12,10,8,6,4,0.12,0.10) that no longer exist in the trimmed basematrix.NODE_VERSION: ['20', '18', '16']list. GitHub Actions treats anyincludeentry with no matching base combination as a new job using only the keys given in that entry, leavingmatrix.OSundefined;runs-on: ${{ matrix.OS }}then evaluates to''and the run fails before any job executes.includeentries from both files so every remaining entry matches an existingNODE_VERSION/OScombination.Questions
No.
Other
Failing runs: https://github.com/stdlib-js/stdlib/actions/runs/29241867217 and https://github.com/stdlib-js/stdlib/actions/runs/29241447715.
Symptom:
Error when evaluating 'runs-on' for job 'test_install'/'test_npm_install': Unexpected value ''.Validation: YAML syntax checked with Python's
yaml.safe_load; matrix expansion traced by hand for both files, confirming no orphan combinations remain after the fix. Reviewed in three passes: correctness (checked all matrix-using workflows for the same bug pattern; found none elsewhere), regression scope (NODE_VERSION20/18/16 legs and thezulipnotification job untouched, no downstream references to the removed legs), and style/conventions (checked againstdocs/style-guides/git/README.md).Note: sibling workflows (
linux_test.yml,macos_test.yml, etc.) handle the same trimmed-matrix situation by commenting out stale entries rather than deleting them. This PR deletes the orphaned entries outright since they were live, not commented, and were the actual cause of the failure.Note: the
exclude:block inlinux_test_install.ymlreferencingNODE_VERSION0.12/0.10is now fully vestigial. Pre-existing, not touched by this PR — flagging for a maintainer as a possible follow-up cleanup.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, investigating a GitHub Actions run failure and proposing a minimal fix to the affected workflow YAML files.
@stdlib-js/reviewers
Generated by Claude Code