Skip to content

chore: clean-up#13450

Merged
kgryte merged 7 commits into
developfrom
philipp/fix-commit-review-2026-07-13
Jul 13, 2026
Merged

chore: clean-up#13450
kgryte merged 7 commits into
developfrom
philipp/fix-commit-review-2026-07-13

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between ce67b15b and 89717ddc (2026-07-12 → 2026-07-13). Each item was independently verified against the diff, the sibling reference package, and — for the costi slice — the package's own test assertions.

This pull request:

fft/base/fftpack/costi

  • Example/README for fft/base/fftpack/costi (ce67b15b) slice the workspace at 3*N+2 instead of 3*N, skipping past the integer-factor region defined by the file's own layout table and confirmed by test.js:304-305 — the runnable example prints zeros instead of the radix factors; fix workspace.slice( (3*N)+2, (3*N)+2+nf ) to workspace.slice( 3*N, (3*N)+nf ) in examples/index.js:45 and README.md:144.
  • Fix stray 'value2' assertion message in lib/node_modules/@stdlib/fft/base/fftpack/costi/test/test.js (line 303, ce67b15b) to 'returns expected value', matching every other assertion in the file.

random/betaprime

  • Files missed by the betaprime → beta prime pass in b59aade7: lib/node_modules/@stdlib/random/betaprime/docs/repl.txt (3 occurrences) and lib/node_modules/@stdlib/random/betaprime/docs/types/index.d.ts (8 occurrences) still say "betaprime distribution"; update both to "beta prime distribution" for consistency with the rest of the package.

number/uint64/base/get-high-word

  • Fixed copy-paste artifacts from float64 sibling get-high-word in f23740ac: README.md and docs/repl.txt documented signature param as x while lib/main.js/TS decl use a, and README.md/examples/index.js:36 invoked new Uint64.of(...) despite of being a static factory, not a constructor.

blas/ext/base/gfill-less-than

  • 89717ddc cleans up cargo-cult in gfill-less-than: dropped a stray eslint-disable-line max-len in lib/main.js:46 that gfill-equal's identical line doesn't have, and removed the redundant var on the x re-declarations in docs/repl.txt:44,98 to match every other gfill-* sibling.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. Each candidate finding was cross-checked against the actual working-tree file (line/content match), against a sibling reference package under the same parent directory (e.g. gfill-equal for gfill-less-than), and — for the costi off-by-two — against the package's own test assertions (test.js:304-305, which pin the factor region to 3*N, (3*N)+1). Findings that survived only on a single reviewer's read and could not be independently re-verified from the diff were dropped. Deliberately excluded: (a) suggestions to add explanatory comments / Notes bullets that no style-guide rule requires; (b) the costi layout-table example inside lib/main.js JSDoc (workspace.slice( (3*N)-2, (3*N)+2 )), which predates this window and is out of scope; (c) any change that would require touching code outside the 24h diff to remain correct.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was drafted by a scheduled review routine (Claude Code): four independent reviewer agents scanned the last 24 hours of develop commits for objective bugs and unambiguous style-guide violations; only findings that were independently re-verified against the diff and a sibling reference package are included, and each fix was applied narrowly to the exact line and re-read before commit. A human maintainer will audit and promote from draft.


@stdlib-js/reviewers


Generated by Claude Code

claude added 4 commits July 13, 2026 12:24
…pack/costi`

Fixes the off-by-two `workspace.slice( (3*N)+2, ... )` in the runnable
README example and `examples/index.js` (integer factors live at index
`3*N`, per the layout table and the test at `test.js:304-305`), and
tidies the stray `'returns expected value2'` assertion message.
…rations in `random/betaprime`

The `docs/repl.txt` and `docs/types/index.d.ts` files were missed by the
"betaprime" → "beta prime" pass, leaving the REPL help and the
TypeScript JSDoc inconsistent with the README, JSDoc in `lib/`, and
scaffold JSON.
…er/uint64/base/get-high-word`

The README Usage signature and REPL parameter table used `x` while
`lib/main.js`, the TypeScript declaration, and every code example
use `a`; the README and `examples/index.js` also called
`new Uint64.of( ... )` as if `of` were a constructor. Both are
copy-paste artifacts from the `float64` sibling.
…s/ext/base/gfill-less-than`

The trailing `// eslint-disable-line max-len` in `lib/main.js` is absent
from the sibling `gfill-equal` for an identical line, and the two
`> var x = ...` re-declarations inside the REPL example blocks should be
plain re-assignments to match the convention used across the sibling
`gfill-*` packages.
@stdlib-bot

stdlib-bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/gfill-less-than $\\color{green}254/254$
$\\color{green}+0.00\\%$
$\\color{green}17/17$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}254/254$
$\\color{green}+0.00\\%$
fft/base/fftpack/costi $\\color{green}266/266$
$\\color{green}+0.00\\%$
$\\color{green}7/7$
$\\color{green}+0.00\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{green}266/266$
$\\color{green}+0.00\\%$
number/uint64/base/get-high-word $\\color{green}85/85$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{green}85/85$
$\\color{green}+0.00\\%$
random/betaprime $\\color{green}217/217$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}0/0$
$\\color{green}+0.00\\%$
$\\color{green}217/217$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title follow-up fixes for commits merged to develop (2026-07-12 → 2026-07-13) chore: follow-up fixes for commits merged to develop (2026-07-12 → 2026-07-13) Jul 13, 2026
Comment thread lib/node_modules/@stdlib/blas/ext/base/gfill-less-than/lib/main.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/number/uint64/base/get-high-word/docs/repl.txt Outdated
Comment thread lib/node_modules/@stdlib/number/uint64/base/get-high-word/docs/repl.txt Outdated
Comment thread lib/node_modules/@stdlib/number/uint64/base/get-high-word/README.md Outdated
Comment thread lib/node_modules/@stdlib/number/uint64/base/get-high-word/README.md Outdated
Comment thread lib/node_modules/@stdlib/number/uint64/base/get-high-word/README.md Outdated
Comment thread lib/node_modules/@stdlib/number/uint64/base/get-high-word/README.md Outdated
claude added 2 commits July 13, 2026 22:28
…review

Per @kgryte's review: keep `x` as the documented parameter name in
`README.md` and `docs/repl.txt` (matching the `float64` sibling
convention), and use `x` in the Usage example variable. Also drop the
backticks around "integer" in the README description.
…word`

Per @kgryte's review: use `x` as the example variable name in the README
Examples block (and the mirrored `examples/index.js`) to match the
Usage-block and REPL rename.
@kgryte kgryte marked this pull request as ready for review July 13, 2026 22:30
@kgryte kgryte requested a review from a team July 13, 2026 22:30
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 13, 2026
@kgryte kgryte changed the title chore: follow-up fixes for commits merged to develop (2026-07-12 → 2026-07-13) chore: clean-up Jul 13, 2026
@kgryte kgryte merged commit 059dffa into develop Jul 13, 2026
33 checks passed
@kgryte kgryte deleted the philipp/fix-commit-review-2026-07-13 branch July 13, 2026 22:34
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants