chore: clean-up#13450
Merged
Merged
Conversation
…pack/costi` Fixes the off-by-two `workspace.slice( (3*N)+2, ... )` in the runnable README example and `examples/index.js` (integer factors live at index `3*N`, per the layout table and the test at `test.js:304-305`), and tidies the stray `'returns expected value2'` assertion message.
…rations in `random/betaprime` The `docs/repl.txt` and `docs/types/index.d.ts` files were missed by the "betaprime" → "beta prime" pass, leaving the REPL help and the TypeScript JSDoc inconsistent with the README, JSDoc in `lib/`, and scaffold JSON.
…er/uint64/base/get-high-word` The README Usage signature and REPL parameter table used `x` while `lib/main.js`, the TypeScript declaration, and every code example use `a`; the README and `examples/index.js` also called `new Uint64.of( ... )` as if `of` were a constructor. Both are copy-paste artifacts from the `float64` sibling.
…s/ext/base/gfill-less-than` The trailing `// eslint-disable-line max-len` in `lib/main.js` is absent from the sibling `gfill-equal` for an identical line, and the two `> var x = ...` re-declarations inside the REPL example blocks should be plain re-assignments to match the convention used across the sibling `gfill-*` packages.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
develop (2026-07-12 → 2026-07-13)develop (2026-07-12 → 2026-07-13)
kgryte
reviewed
Jul 13, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Jul 13, 2026
kgryte
reviewed
Jul 13, 2026
kgryte
reviewed
Jul 13, 2026
kgryte
reviewed
Jul 13, 2026
kgryte
reviewed
Jul 13, 2026
kgryte
reviewed
Jul 13, 2026
…review Per @kgryte's review: keep `x` as the documented parameter name in `README.md` and `docs/repl.txt` (matching the `float64` sibling convention), and use `x` in the Usage example variable. Also drop the backticks around "integer" in the README description.
…word` Per @kgryte's review: use `x` as the example variable name in the README Examples block (and the mirrored `examples/index.js`) to match the Usage-block and REPL rename.
kgryte
approved these changes
Jul 13, 2026
develop (2026-07-12 → 2026-07-13)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetweence67b15band89717ddc(2026-07-12 → 2026-07-13). Each item was independently verified against the diff, the sibling reference package, and — for thecostislice — the package's own test assertions.This pull request:
fft/base/fftpack/costifft/base/fftpack/costi(ce67b15b) slice the workspace at3*N+2instead of3*N, skipping past the integer-factor region defined by the file's own layout table and confirmed bytest.js:304-305— the runnable example prints zeros instead of the radix factors; fixworkspace.slice( (3*N)+2, (3*N)+2+nf )toworkspace.slice( 3*N, (3*N)+nf )inexamples/index.js:45andREADME.md:144.'value2'assertion message inlib/node_modules/@stdlib/fft/base/fftpack/costi/test/test.js(line 303,ce67b15b) to'returns expected value', matching every other assertion in the file.random/betaprimeb59aade7:lib/node_modules/@stdlib/random/betaprime/docs/repl.txt(3 occurrences) andlib/node_modules/@stdlib/random/betaprime/docs/types/index.d.ts(8 occurrences) still say "betaprime distribution"; update both to "beta prime distribution" for consistency with the rest of the package.number/uint64/base/get-high-wordfloat64siblingget-high-wordinf23740ac:README.mdanddocs/repl.txtdocumented signature param asxwhilelib/main.js/TS decl usea, andREADME.md/examples/index.js:36invokednew Uint64.of(...)despiteofbeing a static factory, not a constructor.blas/ext/base/gfill-less-than89717ddccleans up cargo-cult ingfill-less-than: dropped a strayeslint-disable-line max-leninlib/main.js:46thatgfill-equal's identical line doesn't have, and removed the redundantvaron thexre-declarations indocs/repl.txt:44,98to match every othergfill-*sibling.Related Issues
No.
Questions
No.
Other
Validation. Each candidate finding was cross-checked against the actual working-tree file (line/content match), against a sibling reference package under the same parent directory (e.g.
gfill-equalforgfill-less-than), and — for thecostioff-by-two — against the package's own test assertions (test.js:304-305, which pin the factor region to3*N,(3*N)+1). Findings that survived only on a single reviewer's read and could not be independently re-verified from the diff were dropped. Deliberately excluded: (a) suggestions to add explanatory comments / Notes bullets that no style-guide rule requires; (b) thecostilayout-table example insidelib/main.jsJSDoc (workspace.slice( (3*N)-2, (3*N)+2 )), which predates this window and is out of scope; (c) any change that would require touching code outside the 24h diff to remain correct.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was drafted by a scheduled review routine (Claude Code): four independent reviewer agents scanned the last 24 hours of
developcommits for objective bugs and unambiguous style-guide violations; only findings that were independently re-verified against the diff and a sibling reference package are included, and each fix was applied narrowly to the exact line and re-read before commit. A human maintainer will audit and promote from draft.@stdlib-js/reviewers
Generated by Claude Code