stabilize geometric inverse cdf and clean lint warnings#364
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #364 +/- ##
==========================================
- Coverage 94.99% 94.40% -0.60%
==========================================
Files 61 59 -2
Lines 13615 12963 -652
==========================================
- Hits 12934 12238 -696
- Misses 681 725 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@YeungOnion added tests and some lint fixes |
|
Partially merged via cherry-pick rebase onto master (736e412, 72d6630) to preserve author attribution for the testing import cleanup and CI fixes. The inverse_cdf stabilization (bad330b) was not used — the distribution was instead addressed with a different implementation (514a9b9) with explicit panic bounds and num_traits compatibility. All tests pass. |
|
I sat on #343 so long that your changes functionally overlapped. I added in some other changes to more clearly denote the failure modes, #366 identifies some need for how we handle failure modes which has some approach in #377 I kept the safe comparisons to 1.0 let me know if I missed another theme. |
Summary
Geometric::inverse_cdfwith a closed-form implementation to avoid platform-dependent bisection drift (Windows/no_std failure).testing_boilerimports that caused-Dwarningsfailures in coverage/nightly.Testing
cargo fmt -- --checkcargo clippy --all-targets(remaining warnings only in kernel tests:uninlined_format_args, unchanged)cargo test --no-default-features -F rand --target x86_64-pc-windows-gnuorwindows-latestandcargo +nightly llvm-cov --no-report nextest