Repository navigation
Conversation
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a collection tree is saved, only the entries that were moved or added get their order updated. But an entry's order is its position in the whole tree, so anything that just gets pushed down keeps its old number. Add a child to the first page and every page after it is now off by one, and you get ties and a front end sort that no longer matches the tree. With the Eloquent driver that's stored in
entries.order, so it builds up over time.This also updates entries whose position in the tree changed, including after a removal.
That means a change near the top of a big tree updates more entries than before, which is needed since their order really was wrong. To keep it cheap, the order and parent indexes are now written to the cache once per save instead of once per entry. On a 1,000 entry tree that took a save from 265ms to about 155ms.
Fixes #15799
🤖 Generated with Claude Code