Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where a Select field's label disappears from the collapsed set preview after reordering Replicator sets.
When a set moves, its field paths change, and
Field.vuere-stores the preview under the new path by readingreplicatorPreviewfrom the fieldtype's template ref.SelectFieldtypeuses<script setup>but never calleddefineExpose(), so that read came backundefinedand wiped the preview. Since the value itself didn't change, nothing emitted it again.This PR fixes it by exposing the fieldtype's
exposeobject, the same way the Text and Revealer fieldtypes already do. The Icon fieldtype had the same problem, so it gets the same change.Fixes #15802