Repository navigation
[6.x] Arabic translations - #15785
Conversation
duncanmcclean
left a comment
There was a problem hiding this comment.
Thanks for this! Just a couple of things to fix before we merge:
-
licensing_config_cached_warning(lang/ar/messages.php):.envis wrapped in backticks, but this string is rendered as raw HTML, not markdown, so the backticks show up literally. Could you use<code>.env</code>instead, like you've done withphp artisan config:cache? -
licensing_incorrect_key_format_body(lang/ar/messages.php): the English string has a link to statamic.com (<a href="https://statamic.com" class="underline">statamic.com</a>), but it's been dropped from the Arabic version. Could you add the<a>tag back so the link is still clickable?
Not a blocker, but in markdown.php, the & is missing from the <h2> heading and there's an extra </p> after the inline code paragraph. Would be good to tidy those up while you're in there.
|
Checked and fixed. |
There was a problem hiding this comment.
Thanks for this! It's a big improvement on what we had before.
I had an LLM look through it, and it spotted a couple of things that need doing. Some terms were only renamed in some places, so the same screen can end up showing two different names for the same thing:
- Super Admin: In
ar.json, "Super Admin" is "مسؤول بصلاحيات فائقة" and "Super User" is "مستخدم بصلاحيات فائقة", butpermissions.superanduser_wizard_super_admin_instructionsuse "المسؤول الأعلى". In the user wizard those two sit right next to each other. It'd be good to pick one. - Asset container: "Asset Containers" is now "مخازن الملفات", but "Container", "Create Container", "Edit Container", "Delete Container" and "This container is empty" in
ar.jsonstill say "حاوية", and so doasset_container_handle_instructionsandasset_container_intro. The asset browser shows those right under the "مخازن الملفات" heading. - Configure:
messages.phpandpermissions.phpnow use "إعداد", but every "Configure …" key inar.jsonstill uses "تكوين", so page titles and permission labels won't match.
It flagged a few smaller things too. These ones are optional:
text.config.append/prependandrange.config.append/prepend/min/maxstill say right/left. Since the CP is right-to-left in Arabic, appended text actually shows on the left, so start/end wording might be better. (This was already wrong before your PR, but you're touching those lines anyway.)configure_globals_descsays "المجموعات العامة", while its group label is "المتغيرات العامة".- "مرشح" for "Filter" can also mean "candidate". "تصفية" / "عامل تصفية" might be more familiar.
- "Widgets" → "عناصر واجهة المستخدم" loses the dashboard-widget meaning a bit, and "Warm" → "تهيئة ذاكرة التخزين المؤقت" is quite long for a button.
If you could have a look and see what you can do, that would be great!
|
Thanks for the detailed review. I’ve aligned the Super Admin and asset-container terminology, standardized “Configure,” and applied the suggested wording updates for RTL, globals, filter, widget, and cache-warming. Super Admin: المسؤول الأعلى If you have any suggestions, I would be happy to help. |
duncanmcclean
left a comment
There was a problem hiding this comment.
Thanks for sorting these out, looks great! 🙌
No description provided.