Repository navigation
[6.x] Bump prosemirror-view to 1.42.8 - #15752
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request bumps
prosemirror-viewfrom 1.42.3 to 1.42.8, which makes Bard-heavy entries load much faster.Large Bard entries were slow to load because, every time Vue rendered something inside a Bard field (like the fields in a set), ProseMirror would read the browser's selection. Reading the selection forces Chrome to recalculate styles and layout for the whole page. On an entry with 40 Bard sets, that happened ~940 times while the page loaded.
ProseMirror fixed this upstream in 1.42.7 (aa383830b) by only reading the selection when the editor has focus. 1.42.8 also fixes a widget rendering regression from 1.42.6.
prosemirror-modelis bumped to 1.25.12, as required by 1.42.8.In my testing (40-set Bard entry, production build), the page went from ~11.4s to ~2.5s to load, with style recalculation going from ~10s to ~1.1s.
The only change is
package-lock.json. Tiptap already allows^1.42.3.Related: #13385
Related: #15158