Repository navigation
[6.x] Fix duplicate labels on Bard, Replicator & Group fields in Grid tables - #15750
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where Bard, Replicator and Group fields inside a Grid (in table mode) would show their label twice: once in the table header, and again inside the cell.
This was happening because the CSS rule added in #14987 (to show the labels of fields inside these fieldtypes) targets
.bard-fieldtype,.replicator-fieldtypeand.group-fieldtype. The cell's own field has the same class, so the rule was also showing the cell's own label & instructions.This PR fixes it by only targeting the labels of fields nested inside the container fieldtype.
Before
After
Fixes #15749
Caused by #14987