Repository navigation
[6.x] Keep crop copies in the asset selector - #15741
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where cropping an asset from the asset selector and choosing "Save as Copy" would take you away from the entry you were editing.
This was happening because the asset browser's editor redirects to the new copy after cropping, which makes sense on the Assets page, but not when the browser is being used as a selector. If the entry had unsaved changes, you'd also get the "You have unsaved changes" dialog.
This PR fixes it by disabling the redirect when the browser is autoselecting uploads (ie. when it's being used as a selector). Instead, the editor closes and the copy gets selected, just like an upload would be.
Cropping from an assets field itself was fixed in #15284.
Fixes #15739