[6.x] Invalidate moved entries' new URLs when a collection tree is saved - #15361
Open
duncanmcclean wants to merge 1 commit into
Open
[6.x] Invalidate moved entries' new URLs when a collection tree is saved#15361duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01168bNZoPReRH5qEHkfmi3s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where a statically cached 404 would keep being served after the collection tree was changed so that the URL became valid. For example, with half-measure static caching, visiting
/parent/childwhile both pages are top level caches a 404, and movingchildbelowparentin the tree leaves that 404 in place.This was happening because #14386 only invalidates the URLs moved entries are leaving behind, which is done during
CollectionTreeSavingwhile the old URLs can still be resolved. Nothing invalidated the URLs the entries are moving to, so any cached 404 at the new URL stuck around.This PR fixes it by having the invalidator also invalidate the URLs of any entries whose ancestry changed when the tree is saved. By the time the
CollectionTreeSavedevent is handled, the entry URIs have already been updated, so the new URLs resolve correctly.Fixes #10758