[6.x] Forms 2: Scope submission counts and fake submissions to the selected site - #15350
Open
duncanmcclean wants to merge 2 commits into
Open
[6.x] Forms 2: Scope submission counts and fake submissions to the selected site#15350duncanmcclean wants to merge 2 commits into
duncanmcclean wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qe1g6yd25kh7oTxtWfzB95
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qe1g6yd25kh7oTxtWfzB95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the forms index could show a submission count, but clicking through to the submissions listing showed nothing.
This was happening because the forms index counted submissions across all sites, while the submissions listing auto-applies the selected site filter. Any submissions belonging to another site were counted but never listed.
This PR fixes it by scoping the count on the forms index to the selected site, the same way the collections index does.
This PR also assigns the selected site to generated fake submissions. Previously they never had a site set, so they always resolved to the default site and disappeared from the listing whenever another site was selected. Emails for full pipeline fake submissions are now sent using the submission's site rather than the default site.