Repository navigation
Reject malformed Base64 padding consistently on Windows PowerShell - #32
Merged
Merged
Conversation
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows PowerShell 5.1/.NET Framework accepted
Zm8==even though the existing malformed-input regression requires rejection. Hosted release-candidate run 43073726291 reproduced this difference while the other three runtimes passed.Validate normalized padded input length and terminal padding shape explicitly before delegating decoding to .NET. Preserve the previously reviewed PR #28 encoding/pipeline behavior and all 31 existing regressions; add three over-padding/padding-only cases. This follow-up contains no out/ artifacts and targets the module development branch.
The source-only, credential-free workflow validates source and an ephemeral generated package on Windows PowerShell 5.1, Windows pwsh, Linux and macOS. Local macOS pwsh 7.7.0/Pester 4.10.1 passes all 34 regressions.
References #22 and #29. No issue closure, Gallery upload or master change is requested. After this follow-up passes, selectively port the reviewed guard/tests to the 1.3.0 release candidate and regenerate its package.