Skip to content

Fix early-readiness version check for ACS 4.9 #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladbologa merged 1 commit into from
Aug 14, 2026
+2 −2
Merged

Fix early-readiness version check for ACS 4.9 #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/stackroxversions/constraints.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

var (
SupportsAdditionalPrinterColumnsConstraint = func() *semver.Constraints {
constraint, err := semver.NewConstraint(">= 4.9.0")
constraint, err := semver.NewConstraint(">= 4.10.0")
if err != nil {
Comment thread
vladbologa marked this conversation as resolved.
panic("invalid semver constraint")
}
Expand All @@ -18,7 +18,7 @@ var (
)

// SupportsAdditionalPrinterColumns checks if the provided main image tag supports
// the additional printer columns (i.e., >= 4.9.0).
// the additional printer columns (i.e., >= 4.10.0).
func SupportsAdditionalPrinterColumns(version string) (bool, error) {
Comment thread
vladbologa marked this conversation as resolved.
// We also need to support versions such as 4.11.0-937-gf0da38f1a.
version, _, _ = strings.Cut(version, "-")
Expand Down
Loading