fix: handle nil auth when pulling unauthenticated images#197
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
When no credentials match an image, getAuthsForImage returns a nil AuthConfig entry to attempt an unauthenticated pull. The logger call in Run() dereferenced this nil pointer to extract ServerAddress and Username fields, causing a panic. Extract pullLogger helper that safely builds a logger for pull attempts, omitting auth fields when auth is nil. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
e92d209 to
6e037e8
Compare
vladbologa
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/main.go:81when credential providers are configured but no credentials match the image being pulled (e.g. public images).getAuthsForImageintentionally returns anilAuthConfigentry for unauthenticated pulls, but the logger call inRun()dereferenced it to extractServerAddressandUsername.pullLoggerhelper that safely builds a logger for pull attempts, omitting auth fields when auth is nil.Test plan
docker.io/library/busyboxwith credential provider integration enabledgo build ./internal/compiles cleanly🤖 Generated with Claude Code