feat: add OCP modes for kubelet credential provider integration#196
Open
porridge wants to merge 2 commits into
Open
feat: add OCP modes for kubelet credential provider integration#196porridge wants to merge 2 commits into
porridge wants to merge 2 commits into
Conversation
Add support for OpenShift Container Platform credential provider paths, using /etc/kubernetes/credential-providers/ for config and /usr/libexec/kubelet-image-credential-provider-plugins for binaries, matching the paths used by the OpenShift machine-config-operator. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Add support for OpenShift Container Platform credential provider paths with cloud-specific modes: OCP-GCR, OCP-ECR, OCP-ACR. Each mode uses the corresponding credential provider config from /etc/kubernetes/credential-providers/ and binaries from /usr/libexec/kubelet-image-credential-provider-plugins, matching the paths used by the OpenShift machine-config-operator. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OCP-GCR,OCP-ECR,OCP-ACRas supported modes for--use-kubelet-image-credential-integration, for OCP clusters on GCP, AWS, and Azure respectively.gcr-credential-provider.yaml,ecr-credential-provider.yaml,acr-credential-provider.yaml) from/etc/kubernetes/credential-providers/and binaries from/usr/libexec/kubelet-image-credential-provider-plugins, matching the paths used by the OpenShift machine-config-operator.Test plan
OCP-GCRmode — volume mounts work, credential provider plugin initializes successfully (1 plugin loaded)🤖 Generated with Claude Code