Skip to content

feat: add OCP modes for kubelet credential provider integration#196

Open
porridge wants to merge 2 commits into
masterfrom
feat/ocp-credential-provider
Open

feat: add OCP modes for kubelet credential provider integration#196
porridge wants to merge 2 commits into
masterfrom
feat/ocp-credential-provider

Conversation

@porridge

@porridge porridge commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add OCP-GCR, OCP-ECR, OCP-ACR as supported modes for --use-kubelet-image-credential-integration, for OCP clusters on GCP, AWS, and Azure respectively.
  • Each mode uses the corresponding cloud-specific credential provider config (gcr-credential-provider.yaml, ecr-credential-provider.yaml, acr-credential-provider.yaml) from /etc/kubernetes/credential-providers/ and binaries from /usr/libexec/kubelet-image-credential-provider-plugins, matching the paths used by the OpenShift machine-config-operator.

Test plan

  • Deployed on an OCP/GCP cluster with OCP-GCR mode — volume mounts work, credential provider plugin initializes successfully (1 plugin loaded)

🤖 Generated with Claude Code

Add support for OpenShift Container Platform credential provider paths,
using /etc/kubernetes/credential-providers/ for config and
/usr/libexec/kubelet-image-credential-provider-plugins for binaries,
matching the paths used by the OpenShift machine-config-operator.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: d5a10d9c-cd89-4be9-8ce8-c66583d86dd3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/ocp-credential-provider

Comment @coderabbitai help to get the list of available commands and usage tips.

Add support for OpenShift Container Platform credential provider paths
with cloud-specific modes: OCP-GCR, OCP-ECR, OCP-ACR. Each mode uses
the corresponding credential provider config from
/etc/kubernetes/credential-providers/ and binaries from
/usr/libexec/kubelet-image-credential-provider-plugins, matching the
paths used by the OpenShift machine-config-operator.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@porridge porridge changed the title feat: add OCP mode for kubelet credential provider integration feat: add OCP modes for kubelet credential provider integration Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant