Skip to content

ROX-34502: read TLS certificates from disk on each gRPC connection attempt #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladbologa merged 1 commit into from
Jun 10, 2026
+5 −2
Merged

ROX-34502: read TLS certificates from disk on each gRPC connection attempt #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ possible include a PR number for easier tracking.

## Next

* ROX-34502: reload mTLS certificates on each gRPC connection attempt (#788)
* chore: add formatting and linting to integration test code (#783, #784)
* feat: add code coverage with cargo-llvm-cov and Codecov upload (#745)

Expand Down
6 changes: 4 additions & 2 deletions fact/src/output/grpc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,12 @@ impl Client {
}

async fn run(&mut self) -> anyhow::Result<bool> {
let connector = self.get_connector().await?;
loop {
// Re-read certs on each connection attempt so rotated certificates
// on disk are picked up on the next reconnect.
let connector = self.get_connector().await?;
info!("Attempting to connect to gRPC server...");
let channel = match self.create_channel(connector.clone()).await {
let channel = match self.create_channel(connector).await {
Ok(channel) => channel,
Err(e) => {
debug!("Failed to connect to server: {e:?}");
Expand Down
Loading