Delegate recovery middleware to toolhive-core with observability hooks - #6145
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6145 +/- ##
==========================================
- Coverage 72.63% 72.56% -0.08%
==========================================
Files 736 736
Lines 76355 76340 -15
==========================================
- Hits 55463 55398 -65
- Misses 16955 17019 +64
+ Partials 3937 3923 -14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rdimitrov
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 1 of the toolhive→toolhive-core migration:
pkg/recoverybecomes a thin shim overtoolhive-core/recovery(v0.0.36, stacklok/toolhive-core#203), keeping ToolHive's observability wiring:WithPanicHandlerhook is wired to a localpanicHandler:RecordError→ OTel spanRecordError+ error status (sanitized message, no panic value in telemetry)ReportPanic→sentry.RecoverPanic(raw value, so panics still appear as Sentry Issues)ErrAbortHandlerre-panic semantics now live in core; the existingTestRecoveryMiddleware_RePanicsErrAbortHandlerexercises them through the shim unchanged.MiddlewareType,FactoryMiddleware,CreateMiddleware) and theMiddlewaresignature are unchanged — callers (pkg/api/server.go,pkg/runner/*,pkg/vmcp/server) untouched.Net −28 LOC. Bumps
toolhive-coreto v0.0.36.Test plan
task build,task lint-fix— cleango test ./pkg/recovery/... ./pkg/runner/... ./pkg/api/... ./pkg/vmcp/server/...— all pass